Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add asynchronous hardware components documentation #1961

Merged
merged 5 commits into from
Dec 20, 2024
Merged

Add asynchronous hardware components documentation #1961

merged 5 commits into from
Dec 20, 2024

Conversation

saikishor
Copy link
Member

Add missing docs from #1567

christophfroehlich
christophfroehlich requested changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we list the parameters explicitely before they are introduced in the example? Please add a line to the release_notes as well.

hardware_interface/doc/asynchronous_components.rst Outdated Show resolved Hide resolved
christophfroehlich
christophfroehlich approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it's perfect 👍

@saikishor
Copy link
Member Author

Now it's perfect 👍

Thank you for fixing it

@christophfroehlich christophfroehlich merged commit 8848424 into ros-controls:master Dec 20, 2024
5 checks passed
@christophfroehlich christophfroehlich deleted the add/async/hw/docs branch December 20, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophfroehlich christophfroehlich christophfroehlich approved these changes

@aprotyas aprotyas Awaiting requested review from aprotyas

@destogl destogl Awaiting requested review from destogl

@Maverobot Maverobot Awaiting requested review from Maverobot

@peterdavidfagan peterdavidfagan Awaiting requested review from peterdavidfagan

@rosterloh rosterloh Awaiting requested review from rosterloh

@VX792 VX792 Awaiting requested review from VX792

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saikishor @christophfroehlich