Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverage: Fail CI if codecov-action fails #14

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

fmauch
Copy link
Contributor

@fmauch fmauch commented Feb 21, 2024

By default, the pipeline returns success even if the upload fails. This is misleading in my opinion.

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I didn't know about that option.

@christophfroehlich christophfroehlich merged commit 9fbc92e into ros-controls:master Feb 22, 2024
2 checks passed
@fmauch fmauch deleted the patch-1 branch February 22, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants