Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail on dnf check-update #19

Merged
merged 1 commit into from
Feb 25, 2024
Merged

Conversation

christophfroehlich
Copy link
Contributor

@fmauch neither am I experienced with RHEL ;)

dnf check-update has a nonzero exit code if there are updates -> causing the workflow to fail.
There would be a --refresh option for dnf install, but I don't know how to pass that via rosdep.

https://github.com/ros-controls/ros2_controllers/actions/runs/8028858148/job/21943668352?pr=831#step:5:47

Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christophfroehlich christophfroehlich merged commit dd3cbe3 into master Feb 25, 2024
2 checks passed
@christophfroehlich christophfroehlich deleted the rhel_dont_fail branch February 25, 2024 10:22
@christophfroehlich
Copy link
Contributor Author

Retriggering the earlier failed workflow still fails: it seems that github uses the reusable workflow files from the time of creating the job
https://github.com/ros-controls/control_toolbox/actions/runs/8033254683/job/21951660052?pr=190#step:1:37

@christophfroehlich
Copy link
Contributor Author

Retriggering the earlier failed workflow still fails: it seems that github uses the reusable workflow files from the time of creating the job https://github.com/ros-controls/control_toolbox/actions/runs/8033254683/job/21951660052?pr=190#step:1:37

Explaining this behavior:
https://docs.github.com/en/actions/using-workflows/reusing-workflows#re-running-workflows-and-jobs-with-reusable-workflows

Re-run all worked:
https://github.com/ros-controls/control_toolbox/actions/runs/8033254683?pr=190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants