Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark everything under /opt/ros a system header #191

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Mark everything under /opt/ros a system header #191

merged 2 commits into from
Dec 17, 2024

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Dec 9, 2024 •
edited
Loading

We had warnings from upstream packages passing to our builds, resulting in clang jobs to fail

I propose excluding all system headers from these checks

see https://clang.llvm.org/docs/UsersManual.html#controlling-diagnostics-in-system-headers

@christophfroehlich christophfroehlich marked this pull request as draft December 9, 2024 22:10
saikishor
saikishor approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works with ros-controls/ros2_control#1918

@christophfroehlich christophfroehlich marked this pull request as ready for review December 10, 2024 18:29
fmauch
fmauch approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems reasonable.

bmagyar
bmagyar approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100%

@bmagyar bmagyar merged commit 291b22c into master Dec 17, 2024
10 checks passed
@bmagyar bmagyar deleted the exclude_system_header branch December 17, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikishor saikishor saikishor approved these changes

@bmagyar bmagyar bmagyar approved these changes

@fmauch fmauch fmauch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@christophfroehlich @fmauch @bmagyar @saikishor