Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paths for lcov/codecov #20

Merged
merged 7 commits into from
Feb 28, 2024
Merged

Fix paths for lcov/codecov #20

merged 7 commits into from
Feb 28, 2024

Conversation

christophfroehlich
Copy link
Contributor

codecov did not work with the path I configured for the checkout. It seems that the custom action still works without giving the explict path to colcon list -> no need for the path -> lcov/codecov works with the default path without further changes.

https://github.com/ros-controls/control_toolbox/actions/runs/8070248887/job/22050684141
https://app.codecov.io/gh/ros-controls/control_toolbox/commit/f5277a3e01eaea3557651e5d66a178df56f002b7/tree

image

Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good. This was one of the things going weird about the v4 migration of the codecov action, so we might attempt to update this. Will do that with low priority.

@christophfroehlich christophfroehlich merged commit 92905ae into master Feb 28, 2024
2 checks passed
@christophfroehlich christophfroehlich deleted the lcov_paths branch February 28, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants