Touchup mecanum (#27)

* Update release notes * Update maintainers * Update compile flags * Fix compiler errors
ros-controls · Nov 18, 2024 · 0454833 · 0454833
1 parent 9317768
commit 0454833
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 7 deletions.
diff --git a/doc/release_notes.rst b/doc/release_notes.rst
@@ -50,6 +50,10 @@ joint_trajectory_controller
 
 * Add the boolean parameter ``set_last_command_interface_value_as_state_on_activation``. When set to ``true``, the last command interface value is used as both the current state and the last commanded state upon activation. When set to ``false``, the current state is used for both (`#1231 <https://github.com/ros-controls/ros2_controllers/pull/1231>`_).
 
+mecanum_drive_controller
+************************
+* 🚀 The mecanum_drive_controller was added 🎉 (`#512 <https://github.com/ros-controls/ros2_controllers/pull/512>`_).
+
 pid_controller
 ************************
 * 🚀 The PID controller was added 🎉 (`#434 <https://github.com/ros-controls/ros2_controllers/pull/434>`_).

diff --git a/mecanum_drive_controller/CMakeLists.txt b/mecanum_drive_controller/CMakeLists.txt
@@ -2,7 +2,9 @@ cmake_minimum_required(VERSION 3.16)
 project(mecanum_drive_controller LANGUAGES CXX)
 
 if(CMAKE_CXX_COMPILER_ID MATCHES "(GNU|Clang)")
-  add_compile_options(-Wall -Wextra -Wpedantic)
+  add_compile_options(-Wall -Wextra -Wpedantic -Werror=conversion -Werror=unused-but-set-variable
+  -Werror=return-type -Werror=shadow -Werror=format -Werror=range-loop-construct
+  -Werror=missing-braces)
 endif()
 
 # find dependencies

diff --git a/mecanum_drive_controller/package.xml b/mecanum_drive_controller/package.xml
@@ -5,15 +5,21 @@
   <version>0.0.0</version>
   <description> Implementation of mecanum drive controller for 4 wheel drive.
   </description>
-  <maintainer email="[email protected]">Dr.-Ing. Denis Štogl</maintainer>
+
   <maintainer email="[email protected]">Bence Magyar</maintainer>
-  <maintainer email="[email protected]">Giridhar Bukka</maintainer>
+  <maintainer email="[email protected]">Denis Štogl</maintainer>
+  <maintainer email="[email protected]">Christoph Froehlich</maintainer>
+  <maintainer email="[email protected]">Sai Kishor Kothakota</maintainer>
+
+  <license>Apache License 2.0</license>
+
+  <url type="website">https://control.ros.org</url>
+  <url type="bugtracker">https://github.com/ros-controls/ros2_controllers/issues</url>
+  <url type="repository">https://github.com/ros-controls/ros2_controllers/</url>
 
   <author email="[email protected]">Dr.-Ing. Denis Štogl</author>
   <author email="[email protected]">Giridhar Bukka</author>
 
-  <license>Apache License 2.0</license>
-
   <buildtool_depend>ament_cmake</buildtool_depend>
 
   <build_depend>generate_parameter_library</build_depend>

diff --git a/mecanum_drive_controller/test/test_mecanum_drive_controller.hpp b/mecanum_drive_controller/test/test_mecanum_drive_controller.hpp
@@ -291,8 +291,8 @@ class MecanumDriveControllerFixture : public ::testing::Test
 
   // Controller-related parameters
 
-  std::array<double, 4> joint_state_values_ = {0.1, 0.1, 0.1, 0.1};
-  std::array<double, 4> joint_command_values_ = {101.101, 101.101, 101.101, 101.101};
+  std::array<double, 4> joint_state_values_ = {{0.1, 0.1, 0.1, 0.1}};
+  std::array<double, 4> joint_command_values_ = {{101.101, 101.101, 101.101, 101.101}};
 
   static constexpr double TEST_LINEAR_VELOCITY_X = 1.5;
   static constexpr double TEST_LINEAR_VELOCITY_y = 0.0;