Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove front_steering from steering library #1166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+330 −360

Remove front_steering from steering library

4710c60
Select commit
Loading
Failed to load commit list.
Open

Remove front_steering from steering library #1166

Remove front_steering from steering library
4710c60
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 7, 2024 in 1s

80.32% (-0.04%) compared to c08bdab

View this Pull Request on Codecov

80.32% (-0.04%) compared to c08bdab

Details

Codecov Report

Attention: Patch coverage is 80.26316% with 30 lines in your changes missing coverage. Please review.

Project coverage is 80.32%. Comparing base (c08bdab) to head (4710c60).

Files with missing lines Patch % Lines
...g_controller/src/ackermann_steering_controller.cpp 25.00% 8 Missing and 4 partials ⚠️
...ing_controller/src/bicycle_steering_controller.cpp 33.33% 4 Missing and 2 partials ⚠️
...llers_library/src/steering_controllers_library.cpp 80.00% 4 Missing and 2 partials ⚠️
...ng_controller/src/tricycle_steering_controller.cpp 40.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1166      +/-   ##
==========================================
- Coverage   80.36%   80.32%   -0.04%     
==========================================
  Files         105      105              
  Lines        9389     9393       +4     
  Branches      827      827              
==========================================
  Hits         7545     7545              
+ Misses       1571     1569       -2     
- Partials      273      279       +6
Files with missing lines Coverage Δ
...roller/test/test_ackermann_steering_controller.cpp 100.00% <100.00%> (ø)
...roller/test/test_ackermann_steering_controller.hpp 86.59% <100.00%> (ø)
.../test_ackermann_steering_controller_preceeding.cpp 100.00% <100.00%> (ø)
...ntroller/test/test_bicycle_steering_controller.cpp 100.00% <100.00%> (ø)
...ntroller/test/test_bicycle_steering_controller.hpp 83.75% <100.00%> (+0.63%) ⬆️
...st/test_bicycle_steering_controller_preceeding.cpp 100.00% <100.00%> (ø)
...library/test/test_steering_controllers_library.cpp 100.00% <100.00%> (ø)
...library/test/test_steering_controllers_library.hpp 96.87% <100.00%> (ø)
...troller/test/test_tricycle_steering_controller.cpp 100.00% <100.00%> (ø)
...troller/test/test_tricycle_steering_controller.hpp 85.22% <100.00%> (+0.16%) ⬆️
... and 5 more

... and 3 files with indirect coverage changes

View more details on Codecov