Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parallel_gripper_controller failing tests #1210

Merged

Conversation

saikishor
Copy link
Member

The Parallel gripper controller tests are not passing on the rolling from beginning, I've modified the tests to make it work. However, I had to remove a couple of tests as in the GPL the parameter joint is declared as read_only, and this makes most of the tests doesn't work at all, so I've cleaned them up

@saikishor saikishor marked this pull request as ready for review July 16, 2024 08:29
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use GPL for validation instead of checking params_.joint.empty()? Then there is no need for testing it (see the deleted tests).

Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @christophfroehlich, let's use GenerateParameterLiberry validators instead of testing empty joints.

@saikishor saikishor force-pushed the fix/parallel_gripper_controller/tests branch from 993b6b8 to c8de8b8 Compare July 16, 2024 09:02
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes (haven't tested it with #1206, but I guess you did?)

Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@destogl destogl merged commit b958da3 into ros-controls:master Jul 16, 2024
5 of 20 checks passed
@saikishor saikishor deleted the fix/parallel_gripper_controller/tests branch July 16, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants