-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix parallel_gripper_controller failing tests #1210
fix parallel_gripper_controller failing tests #1210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use GPL for validation instead of checking params_.joint.empty()
? Then there is no need for testing it (see the deleted tests).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @christophfroehlich, let's use GenerateParameterLiberry
validators instead of testing empty joints.
993b6b8
to
c8de8b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes (haven't tested it with #1206, but I guess you did?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The Parallel gripper controller tests are not passing on the rolling from beginning, I've modified the tests to make it work. However, I had to remove a couple of tests as in the GPL the parameter
joint
is declared asread_only
, and this makes most of the tests doesn't work at all, so I've cleaned them upros2_controllers/parallel_gripper_controller/src/gripper_action_controller_parameters.yaml
Lines 11 to 14 in 0bb8880