-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PID Controller] Export state interfaces for easier chaining with other controllers #1214
[PID Controller] Export state interfaces for easier chaining with other controllers #1214
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1214 +/- ##
==========================================
- Coverage 80.39% 80.35% -0.05%
==========================================
Files 105 105
Lines 9357 9392 +35
Branches 821 830 +9
==========================================
+ Hits 7523 7547 +24
- Misses 1557 1570 +13
+ Partials 277 275 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Can't we implement this together with ros-controls/ros2_control#1244? Instead of adding this to every chainable controller? |
@christophfroehlich #1244 is about publishing the interface information to a topic but not exposing as interfaces which is what we need here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks good!
This PR aims to export some state interfaces from the PID controllers that can be used in cascade with other controllers, this helps in not defining separate parameters for command interfaces (The one exported by the PID controller) and the state interfaces that define the same state as the PID controller, and it simplifies the design of the chained controllers