-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug for displaying all controllers (backport #1259) #1271
Conversation
(cherry picked from commit 3be3fe9) # Conflicts: # rqt_joint_trajectory_controller/rqt_joint_trajectory_controller/joint_trajectory_controller.py
Cherry-pick of 3be3fe9 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Let's merge backport #1274 first |
This pull request is in conflict. Could you fix it @bmagyar @destogl @christophfroehlich? |
@Mergifyio rebase |
☑️ Nothing to do
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## humble #1271 +/- ##
==========================================
- Coverage 65.23% 65.22% -0.02%
==========================================
Files 103 103
Lines 11435 11436 +1
Branches 7252 7253 +1
==========================================
- Hits 7460 7459 -1
- Misses 1476 1477 +1
- Partials 2499 2500 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Hi,
When using the rqt_joint_trajectory_controller, not all the controllers are shown on the controller button. This is because the list of limits was not accumulated, and only the last one was considered. This PR fixes this, showing all the valid controllers.
I hope it helps
Francisco
This is an automatic backport of pull request #1259 done by [Mergify](https://mergify.com).