Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add few warning flags to error in all ros2_controllers packages #1370

Merged

Conversation

saikishor
Copy link
Member

Similar to #961

@saikishor saikishor requested a review from bmagyar November 18, 2024 12:27
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.07%. Comparing base (0590c6a) to head (5258d80).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1370      +/-   ##
==========================================
- Coverage   83.07%   83.07%   -0.01%     
==========================================
  Files         115      115              
  Lines       10397    10396       -1     
  Branches      895      894       -1     
==========================================
- Hits         8637     8636       -1     
- Misses       1459     1460       +1     
+ Partials      301      300       -1     
Flag Coverage Δ
unittests 83.07% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...roller/test/test_ackermann_steering_controller.hpp 86.59% <ø> (ø)
...nce_controller/test/test_admittance_controller.hpp 94.79% <ø> (ø)
...ntroller/test/test_bicycle_steering_controller.hpp 83.11% <ø> (ø)
...ster/test/test_force_torque_sensor_broadcaster.cpp 97.82% <100.00%> (ø)
pose_broadcaster/test/test_pose_broadcaster.hpp 93.75% <ø> (ø)
...ensor_broadcaster/src/range_sensor_broadcaster.cpp 85.71% <100.00%> (+1.71%) ⬆️
...broadcaster/test/test_range_sensor_broadcaster.cpp 94.73% <100.00%> (ø)
...library/test/test_steering_controllers_library.hpp 96.87% <ø> (ø)
...troller/test/test_tricycle_steering_controller.hpp 85.05% <ø> (ø)

... and 2 files with indirect coverage changes

---- 🚨 Try these New Features:

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for touching things up :)

Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this increase in clarity.

@destogl destogl merged commit 4f447f4 into ros-controls:master Nov 18, 2024
13 of 19 checks passed
@saikishor saikishor deleted the add_few_warning_flags_to_error branch November 18, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants