-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Add clang job and setup concurrency #1407
Conversation
ddc472b
to
35abc6c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1407 +/- ##
==========================================
- Coverage 83.60% 83.59% -0.01%
==========================================
Files 122 122
Lines 11007 11018 +11
Branches 934 935 +1
==========================================
+ Hits 9202 9211 +9
- Misses 1494 1495 +1
- Partials 311 312 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general. Some castings are new to me hahaa
If the CI is happy, I'm fine with it
I used now explicit iterator's |
(cherry picked from commit 66d160c) # Conflicts: # forward_command_controller/test/test_load_forward_command_controller.cpp # joint_trajectory_controller/src/trajectory.cpp # tricycle_controller/src/tricycle_controller.cpp
Additionally, I added the concurrency settings which now automatically cancel running workflows if anything is pushed to PRs.
https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/control-the-concurrency-of-workflows-and-jobs