-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved tf_prefix based on namespace #1420
Improved tf_prefix based on namespace #1420
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I believe the tests should work as the changes are minimal
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1420 +/- ##
=======================================
Coverage 83.61% 83.61%
=======================================
Files 122 122
Lines 11016 11019 +3
Branches 933 935 +2
=======================================
+ Hits 9211 9214 +3
Misses 1495 1495
Partials 310 310
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing it!
950c9c1
into
ros-controls:master
Co-authored-by: Kees van Teeffelen <[email protected]> (cherry picked from commit 950c9c1)
Fix test related with: #1060