Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an error msg if empty message is received #1424

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Conversation

christophfroehlich
Copy link
Contributor

There existed one branch where a goal is rejected but no error message is given.

@christophfroehlich christophfroehlich added the backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. label Dec 13, 2024
saikishor
saikishor previously approved these changes Dec 13, 2024
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.72%. Comparing base (d32665a) to head (4013b49).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1424   +/-   ##
=======================================
  Coverage   83.71%   83.72%           
=======================================
  Files         122      122           
  Lines       11050    11052    +2     
  Branches      940      940           
=======================================
+ Hits         9251     9253    +2     
  Misses       1489     1489           
  Partials      310      310           
Flag Coverage Δ
unittests 83.72% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ory_controller/src/joint_trajectory_controller.cpp 83.95% <100.00%> (+0.04%) ⬆️

@bmagyar bmagyar merged commit 337127a into master Dec 17, 2024
17 of 20 checks passed
@bmagyar bmagyar deleted the jtc/error_output branch December 17, 2024 06:31
mergify bot pushed a commit that referenced this pull request Dec 17, 2024
saikishor pushed a commit that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants