-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an error msg if empty message is received #1424
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophfroehlich
added
the
backport-humble
This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
label
Dec 13, 2024
github-actions
bot
requested review from
DasRoteSkelett,
destogl,
homalozoa,
livanov93,
moriarty,
Raivias and
saikishor
December 13, 2024 11:15
saikishor
previously approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1424 +/- ##
=======================================
Coverage 83.71% 83.72%
=======================================
Files 122 122
Lines 11050 11052 +2
Branches 940 940
=======================================
+ Hits 9251 9253 +2
Misses 1489 1489
Partials 310 310
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bmagyar
approved these changes
Dec 17, 2024
mergify bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
(cherry picked from commit 337127a)
saikishor
pushed a commit
that referenced
this pull request
Dec 17, 2024
Co-authored-by: Christoph Fröhlich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-humble
This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There existed one branch where a goal is rejected but no error message is given.