Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update position controller package.xml #1431

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Update position controller package.xml #1431

merged 1 commit into from
Dec 18, 2024

Conversation

delipl
Copy link
Contributor

@delipl delipl commented Dec 18, 2024

Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:

  1. Limited scope. Your PR should do one thing or one set of things. Avoid adding “random fixes” to PRs. Put those on separate PRs.
  2. Give your PR a descriptive title. Add a short summary, if required.
  3. Make sure the pipeline is green.
  4. Don’t be afraid to request reviews from maintainers.
  5. New code = new tests. If you are adding new functionality, always make sure to add some tests exercising the code and serving as live documentation of your original intention.

To send us a pull request, please:

  • Fork the repository.
  • Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
  • Ensure local tests pass. (colcon test and pre-commit run (requires you to install pre-commit by pip3 install pre-commit)
  • Commit to your fork using clear commit messages.
  • Send a pull request, answering any default questions in the pull request interface.
  • Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.

christophfroehlich
christophfroehlich approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@christophfroehlich christophfroehlich added the backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. label Dec 18, 2024
@christophfroehlich christophfroehlich merged commit a09e7af into ros-controls:master Dec 18, 2024
22 of 24 checks passed
mergify bot pushed a commit that referenced this pull request Dec 18, 2024
@delipl @mergify
Update position controller package.xml (#1431)
4f5b6f9 
(cherry picked from commit a09e7af)

# Conflicts:
#	position_controllers/package.xml
@mergify mergify bot mentioned this pull request Dec 18, 2024
Merged
6 tasks
christophfroehlich pushed a commit that referenced this pull request Dec 18, 2024
@mergify @delipl
Update position controller package.xml (backport #1431) (#1432)
1648033 
Co-authored-by: Jakub "Deli" Delicat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikishor saikishor saikishor approved these changes

@christophfroehlich christophfroehlich christophfroehlich approved these changes

@bmagyar bmagyar Awaiting requested review from bmagyar

@destogl destogl Awaiting requested review from destogl

@LukasMacha97 LukasMacha97 Awaiting requested review from LukasMacha97

@Maverobot Maverobot Awaiting requested review from Maverobot

@progtologist progtologist Awaiting requested review from progtologist

@Raivias Raivias Awaiting requested review from Raivias

@VX792 VX792 Awaiting requested review from VX792

Assignees
No one assigned
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@delipl @christophfroehlich @saikishor