Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(timeout): do not reset steer wheels to 0. on timeout (backport #1289) #1452

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 29, 2024

Instead of setting the incoming twist command velocity to zero, we should only set the wheel commands to zero without altering the steering angles in order to avoid in-place steering of the wheels.


This is an automatic backport of pull request #1289 done by Mergify.

Copy link
Contributor Author

mergify bot commented Dec 29, 2024

Cherry-pick of 1004054 has failed:

On branch mergify/bp/humble/pr-1289
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 1004054.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   steering_controllers_library/test/test_steering_controllers_library.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   doc/release_notes.rst
	both modified:   steering_controllers_library/src/steering_controllers_library.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link

codecov bot commented Dec 29, 2024

Codecov Report

Attention: Patch coverage is 26.31579% with 14 lines in your changes missing coverage. Please review.

Project coverage is 66.72%. Comparing base (5fcc9fd) to head (5e2adf9).
Report is 24 commits behind head on humble.

Files with missing lines Patch % Lines
...library/test/test_steering_controllers_library.cpp 0.00% 0 Missing and 12 partials ⚠️
...llers_library/src/steering_controllers_library.cpp 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #1452      +/-   ##
==========================================
+ Coverage   65.27%   66.72%   +1.44%     
==========================================
  Files         108      113       +5     
  Lines       12562    13337     +775     
  Branches     7805     8245     +440     
==========================================
+ Hits         8200     8899     +699     
+ Misses       1522     1442      -80     
- Partials     2840     2996     +156     
Flag Coverage Δ
unittests 66.72% <26.31%> (+1.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...llers_library/src/steering_controllers_library.cpp 71.20% <71.42%> (+0.43%) ⬆️
...library/test/test_steering_controllers_library.cpp 53.63% <0.00%> (-3.92%) ⬇️

... and 3 files with indirect coverage changes

@bmagyar bmagyar merged commit e247c1c into humble Dec 29, 2024
13 of 14 checks passed
@bmagyar bmagyar deleted the mergify/bp/humble/pr-1289 branch December 29, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants