Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EOL] Drop Foxy #641

Merged
merged 1 commit into from
Jun 2, 2023
Merged

[EOL] Drop Foxy #641

merged 1 commit into from
Jun 2, 2023

Conversation

moriarty
Copy link
Contributor

@moriarty moriarty commented Jun 1, 2023

- Foxy now past EOL date of May 2023

Signed-off-by: Alex Moriarty <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #641 (74088db) into master (e7f9962) will increase coverage by 0.70%.
The diff coverage is 34.80%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #641      +/-   ##
==========================================
+ Coverage   35.78%   36.48%   +0.70%     
==========================================
  Files         189        7     -182     
  Lines       17570      677   -16893     
  Branches    11592      358   -11234     
==========================================
- Hits         6287      247    -6040     
+ Misses        994      134     -860     
+ Partials    10289      296    -9993     
Flag Coverage Δ
unittests 36.48% <34.80%> (+0.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontroller/test/test_load_diff_drive_controller.cpp 11.11% <0.00%> (ø)
diff_drive_controller/src/odometry.cpp 42.16% <11.11%> (ø)
diff_drive_controller/src/speed_limiter.cpp 46.55% <11.11%> (ø)
...ive_controller/test/test_diff_drive_controller.cpp 17.62% <12.08%> (ø)
...iff_drive_controller/src/diff_drive_controller.cpp 46.93% <46.66%> (ø)
...de/diff_drive_controller/diff_drive_controller.hpp 100.00% <100.00%> (ø)
...troller/include/diff_drive_controller/odometry.hpp 100.00% <100.00%> (ø)

... and 189 files with indirect coverage changes

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christophfroehlich
Copy link
Contributor

Also related to ros-controls/control.ros.org#101 ;)

Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@destogl destogl merged commit 96320c6 into ros-controls:master Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants