[JTC] Cancel active goal in on_deactivate #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophfroehlich
added
backport-humble
github-actions
bot
requested review from
bijoua29,
bmagyar,
DasRoteSkelett,
destogl,
duringhof,
olivier-stasse and
saikishor
christophfroehlich
force-pushed
the
jtc/cancel_goal_deactivate
branch
from
1fa82db to
6d12abf
Compare
saikishor
approved these changes
Jan 4, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #962 +/- ##
==========================================
- Coverage 47.82% 47.22% -0.61%
==========================================
Files 41 41
Lines 3862 3871 +9
Branches 1816 1827 +11
==========================================
- Hits 1847 1828 -19
- Misses 754 775 +21
- Partials 1261 1268 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 11, 2024
(cherry picked from commit fdd6142)
mergify bot
pushed a commit
that referenced
this pull request
Jan 11, 2024
(cherry picked from commit fdd6142)
bmagyar
pushed a commit
that referenced
this pull request
Jan 11, 2024
bmagyar
pushed a commit
that referenced
this pull request
Jan 11, 2024
henrygerardmoore
pushed a commit
to henrygerardmoore/ros2_controllers
that referenced
this pull request
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, an active goal is not cancelled if on_deactivate is called. This PR changes this behavior now.
I also removed an unnecessary set_hold_position() call in the preempt_active_goal.