Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

festival_plugin: add support for different encodings #249

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

peci1
Copy link
Contributor

@peci1 peci1 commented Apr 3, 2024

Needed for e.g. festival-czech, which expects source text in ISO-8859-2.

The implementation tries to be as unintrusive as possible. No previous use-cases should be broken (except for voices with : in their name, but I don't think there are any).

To test:

sudo apt install festival-czech
rosrun sound_play soundplay_node.py &
rostopic pub -1 /robotsound sound_play/SoundRequest "{sound: -3, command: 1, volume: 1.0, arg: 'Ahoj lidi a roboti, jak se máte? Testujeme háčky a čárky', arg2: 'voice_czech_ph:ISO-8859-2'}"

Without the correct encoding, you hear "neznámý" several times instead of the diacritics: https://translate.google.com/?sl=cs&tl=en&text=nezn%C3%A1m%C3%BD&op=translate .

@knorth55 knorth55 merged commit 6baeb07 into ros-drivers:master Apr 3, 2024
1 check passed
@peci1
Copy link
Contributor Author

peci1 commented Apr 3, 2024

Thanks for the quick action!

@peci1
Copy link
Contributor Author

peci1 commented Aug 10, 2024

@knorth55 do you plan a Noetic release? This feature is still not available in binary releases if I'm not mistaken.

@knorth55
Copy link
Member

@peci1 Oh thanks! I will release the new version!

@knorth55
Copy link
Member

I made a release PR.
ros/rosdistro#42432

@peci1
Copy link
Contributor Author

peci1 commented Aug 13, 2024

Thanks!

@knorth55
Copy link
Member

Now the new version is released: ros/rosdistro#42432

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants