added master-slave configuration

[dariodenardi]

I fixed a small bug in stereo_synced.launch.py and added a master-slave configuration

[berndpfrommer]

camera_params2 has a lot of code replication wrt camera_params1. Could you please clean that up?

[berndpfrommer]

Also please fix the formatting errors in the launch script.

[berndpfrommer]

One of the checks failed due to a copyright formatting issue that was not caused by your commits, i.e. that was pre-existing and somehow not flagged before. My most recent commits fix that, along with other python formatting issues that unfortunately are currently not flagged by the CI tests. So please rebase to master before fixing above issues.

[berndpfrommer]

With the new code, are all the parameters set for camera2? For example "gain" does not seem to be set.
I suggest the following: rather than having the conditional for "master" in make_camera_node(), pass in the camera parameters as an an argument (instead of arch_type). Pass in different camera parameters for camera2 than for camera1.
As for the camera parameters: use the camera parameters for e.g. camera1, and replace the values that differ for camera2. That makes it clearer what the difference is between master and slave. You might find this link helpful for how to replace dict values:
https://stackoverflow.com/questions/19773669/python-dictionary-replace-values

[berndpfrommer]

With the new synchronized camera driver in place, this PR has become obsolete.