add dynamic parameters (backport #141) #142
Merged
+50
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ROS 1, a number of things were dynamic - this PR re-adds them using the new ROS 2 paradigm for parameter updating. I've tested this with a Primesense device and am able to disable auto_exposure and auto_white_balance.
mikeferguson
force-pushed
the
backport_141
branch
from
5463573
to
87a78ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ROS 1, a number of things were dynamic - this PR re-adds them using the new ROS 2 paradigm for parameter updating. I've tested this with a Primesense device and am able to disable auto_exposure and auto_white_balance.