-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/straight lead in toolpath #198
Closed
DavidSpielman
wants to merge
11
commits into
ros-industrial:master
from
DavidSpielman:feature/straight_lead_in_toolpath
Closed
Feature/straight lead in toolpath #198
DavidSpielman
wants to merge
11
commits into
ros-industrial:master
from
DavidSpielman:feature/straight_lead_in_toolpath
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marip8
requested changes
Sep 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please drop the first commit that hides the ROS1 packages and drop all commits that change the TPP widget since that is unrelated to this PR
noether_tpp/include/noether_tpp/tool_path_modifiers/straight_approach_modifier.h
Show resolved
Hide resolved
noether_tpp/include/noether_tpp/tool_path_modifiers/straight_approach_modifier.h
Show resolved
Hide resolved
noether_tpp/include/noether_tpp/tool_path_modifiers/straight_approach_modifier.h
Show resolved
Hide resolved
… point on a raster and creates a desired number of points between the offset and the point on the part. The gui currently crashes when the plugin is added
…ch_modifier.cpp in call to header file. Removed some comments from noether_gui/src/widgets/tool_path_modifiers/straight_approach_modifier_widget.cpp
…an eigenvector3d (which allows the tool to be offset in three different axes) and a number of lead in points. The toolpath modifier works as expected but the gui layout still needs to be debugged, the heights and widths of the input parameters are incorrect
…ormat of the widget
DavidSpielman
force-pushed
the
feature/straight_lead_in_toolpath
branch
from
September 13, 2023 19:50
045d951
to
f8161c3
Compare
Closing; replaced by #200 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a toolpath and widget where the user can select an offset height from the first waypoint of each raster and interpolate that height with a desired number of waypoints.