Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/straight lead in toolpath #198

Conversation

DavidSpielman
Copy link
Contributor

Added a toolpath and widget where the user can select an offset height from the first waypoint of each raster and interpolate that height with a desired number of waypoints.
straight_approach_toolpath

Copy link
Member

@marip8 marip8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please drop the first commit that hides the ROS1 packages and drop all commits that change the TPP widget since that is unrelated to this PR

… point on a raster and creates a desired number of points between the offset and the point on the part. The gui currently crashes when the plugin is added
…ch_modifier.cpp in call to header file. Removed some comments from noether_gui/src/widgets/tool_path_modifiers/straight_approach_modifier_widget.cpp
…an eigenvector3d (which allows the tool to be offset in three different axes) and a number of lead in points. The toolpath modifier works as expected but the gui layout still needs to be debugged, the heights and widths of the input parameters are incorrect
@DavidSpielman DavidSpielman force-pushed the feature/straight_lead_in_toolpath branch from 045d951 to f8161c3 Compare September 13, 2023 19:50
@DavidSpielman
Copy link
Contributor Author

Widget is able to offset the starting point of the first point of the raster in the axis that the user specifies. The number of points above the starting point can be modified to adjust the approach speed.
pr_lead_in_z
pr_lead_in_x_and_z

@marip8
Copy link
Member

marip8 commented Sep 15, 2023

Closing; replaced by #200

@marip8 marip8 closed this Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants