-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
image_transport: add nodelet_lazy for image_transport #72
base: noetic-devel
Are you sure you want to change the base?
Conversation
@vrabaud @jack-oquin Please could you review or merge if there is no problem? |
👍 a good idea. Thanks for doing the work! This looks OK to me, but I don't really maintain this particular package. Vincent? |
@vrabaud kindly ping to maintainer |
@jack-oquin Maybe @vrabaud does not maintain this package anymore? |
@jack-oquin @vrabaud Kindly ping to the maintainers. |
1 similar comment
@jack-oquin @vrabaud Kindly ping to the maintainers. |
d1b423b
to
5a3098b
Compare
@jack-oquin @vrabaud @mjcarroll |
@jack-oquin @vrabaud @mjcarroll |
@furushchev Can you update this so that it will target |
@mjcarroll Thank you for the response! Changed the base branch to |
The test failed on debian. It seems it is not related to the change?
|
@jack-oquin @ahcorde How can we proceed with this PR? |
@mjcarroll @ahcorde How can we proceed with this PR? |
@mjcarroll @ahcorde How can we proceed with this PR? |
In this PR, a header for
NodeletLazy
class is added. This isimage_transport
version ofnodelet_topic_tools::NodeletLazy
, which brings zero copy feature of nodelet intoimage_transport
.https://github.com/ros/nodelet_core/blob/indigo-devel/nodelet_topic_tools/include/nodelet_topic_tools/nodelet_lazy.h
related to ros/nodelet_core#75