Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spot-cpp-sdk: 4.1.0-1 in 'humble/distribution.yaml' [bloom] #43794

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mhidalgo-bdai
Copy link
Contributor

Increasing version of package(s) in repository spot-cpp-sdk to 4.1.0-1:

bosdyn

* Prepare for ROS 2 release (#10 <https://github.com/bdaiinstitute/spot-cpp-sdk/issues/10>)
* Patch for ROS 2 release (#9 <https://github.com/bdaiinstitute/spot-cpp-sdk/issues/9>)
* Add Protobuf dev libraries to Spot C++ SDK debian deps (#8 <https://github.com/bdaiinstitute/spot-cpp-sdk/issues/8>)
* No CONFIG modules in Spot C++ SDK CMake config (#7 <https://github.com/bdaiinstitute/spot-cpp-sdk/issues/7>)
* Add gRPC dev libraries to Spot C++ SDK debian deps (#6 <https://github.com/bdaiinstitute/spot-cpp-sdk/issues/6>)
* Add dependencies to Spot C++ SDK debians (#5 <https://github.com/bdaiinstitute/spot-cpp-sdk/issues/5>)
* Update devcontainers for building debians (#4 <https://github.com/bdaiinstitute/spot-cpp-sdk/issues/4>)
* Release v4.1.0 of Boston Dynamics Spot SDK
* Contributors: Andrew Messing, Boston Dynamics SDK Publisher, Michel Hidalgo

@github-actions github-actions bot added the humble Issue/PR is for the ROS 2 Humble distribution label Dec 4, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending a pull request to ROS distro!

This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.

ROS Distro Considerations

Package Considerations

Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.

Need Help?

Please post your questions to Robotics Stack Exchange or refer to the #infra-help channel on our Discord server.


For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

@mhidalgo-bdai
Copy link
Contributor Author

Note this release does not cover RHEL -- protobuf-compiler-grpc is not available in RHEL 8.

@quarkytale
Copy link
Contributor

Holding for Humble sync

@quarkytale quarkytale added the held for sync Issue/PR has been held because the distribution is in a sync hold label Dec 4, 2024
@quarkytale
Copy link
Contributor

Holding for Humble sync

Copy link
Contributor

@audrow audrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhidalgo-bdai, this looks like it has a Boston Dynamics specific license. Can you perhaps change the license? Here's our policy.

Thoughts @tfoote or @clalancette?

@audrow audrow added changes requested Maintainers have asked for changes to the pull request and removed held for sync Issue/PR has been held because the distribution is in a sync hold labels Dec 5, 2024
@mhidalgo-bdai
Copy link
Contributor Author

@mhidalgo-bdai, this looks like it has a Boston Dynamics specific license. Can you perhaps change the license? Here's our policy.

Hi @audrow ! It does have a Boston Dynamics specific license. https://github.com/bdaiinstitute/spot-cpp-sdk is a patched version of https://github.com/boston-dynamics/spot-cpp-sdk that is suitable for ROS 2 release (which we got green light from Boston Dynamics to do), but otherwise equivalent. https://github.com/boston-dynamics/spot-cpp-sdk is licensed under this no warranty, limited liability license that restricts use of their software to their hardware.

We cannot change it without infringing the license, unfortunately. CC @tcappellari-bdai.

@clalancette
Copy link
Contributor

We cannot change it without infringing the license, unfortunately. CC @tcappellari-bdai.

So unfortunately, the problem is that this isn't one of the approved OSI licenses at: https://opensource.org/licenses . So we can't actually tell if we are allowed to redistribute this code or not.

There are 3 ways forward here:

  1. Relicense the code to one of the OSI approved licenses.
  2. Get OSI to approve the license as open-source (this was actually done recently by another package, and while I wouldn't say it was "fast", it only took a couple of months).
  3. Enter into some kind of agreement with OSRF explicitly allowing distribution of the package (there are a couple of packages that are in this category).

@tcappellari-bdai
Copy link

  1. Enter into some kind of agreement with OSRF explicitly allowing distribution of the package (there are a couple of packages that are in this category).

@clalancette is there a specific process/person we should reach out to about this?

@clalancette
Copy link
Contributor

@clalancette is there a specific process/person we should reach out to about this?

We don't really have a process for this; it is almost never done. Nevertheless, you can send an email to [email protected] to see if this is something that can be done in this case.

Copy link

This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label.

@github-actions github-actions bot added the stale Issue/PR hasn't been active in a while and may be closed. label Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested Maintainers have asked for changes to the pull request humble Issue/PR is for the ROS 2 Humble distribution stale Issue/PR hasn't been active in a while and may be closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants