Deprecating all C headers #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CursedRock17 <[email protected]>
ahcorde
requested changes
Jul 12, 2024
include/message_filters/cache.h
Outdated
| @@ -1,342 +1,22 @@ | |||
| // Copyright 2008, Willow Garage, Inc. All rights reserved. | |||
| // Copyright 2024 Open Source Robotics Foundation, Inc. | |||
There was a problem hiding this comment.
Suggested change
| // Copyright 2024 Open Source Robotics Foundation, Inc. | |
| // Copyright 2024 Open Source Robotics Foundation, Inc. | |
| // All rights reserved. |
There was a problem hiding this comment.
to be consistent with the rest of headers, here and in the rest of files
Signed-off-by: CursedRock17 <[email protected]>
This was referenced Jul 15, 2024
|
I added rviz, geometry2, image_common and point_cloud_transport changes too
|
|
ahcorde
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is another and possibly the last needed addition to complete the breakdown of PR #120 in which all C headers are deprecated to C++ headers to solve this issue:
The PR appears to be super messy because I guess renaming files counts as making a whole new file in Git's eyes, but really each old file was renamed to have the
.hpptag with the correct header guard, then a new file.hwas created with a warning message to use the C++ style header, so not too bad.