Skip to content

Commit

Permalink
Refactor GraphCache to support multiple types for the same topic. (#70)
Browse files Browse the repository at this point in the history
* use std::find_if to find matching pubs

Signed-off-by: Yadunund <[email protected]>

* Refactor to support multiple types

Signed-off-by: Yadunund <[email protected]>

* Refactor liveliness token generation

Signed-off-by: Yadunund <[email protected]>

* Map topic types to TopicData

Signed-off-by: Yadunund <[email protected]>

* Store map of types in graph_topics_

Signed-off-by: Yadunund <[email protected]>

* fix bug in deleting and counting topics

Signed-off-by: Yadunund <[email protected]>

* Cleanup liveliness_utils

Signed-off-by: Yadunund <[email protected]>

* Style cleanups.

Signed-off-by: Chris Lalancette <[email protected]>

* Cleanup some of the code in the liveliness.

Also fix a couple of bugs where we were mixing up subscriptions
and publications, leading to incorrect counts.

Signed-off-by: Chris Lalancette <[email protected]>

* Remove Entity::node_info.

Because it returned a reference, it is difficult to
tell the lifetime of it.  It would also be hard to add
in locking in the future.  Since we are reaching through
it in most cases, just return some data directly.

Signed-off-by: Chris Lalancette <[email protected]>

* Remove some uses of auto.

Signed-off-by: Chris Lalancette <[email protected]>

* Return copies from Entity

Signed-off-by: Yadunund <[email protected]>

* Address feedback

Signed-off-by: Yadunund <[email protected]>

---------

Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
Co-authored-by: Chris Lalancette <[email protected]>
  • Loading branch information
Yadunund and clalancette authored Dec 2, 2023
1 parent 8569898 commit 1bfc2c1
Show file tree
Hide file tree
Showing 7 changed files with 974 additions and 565 deletions.
1 change: 1 addition & 0 deletions rmw_zenoh_cpp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ add_library(rmw_zenoh_cpp SHARED
src/detail/identifier.cpp
src/detail/graph_cache.cpp
src/detail/guard_condition.cpp
src/detail/liveliness_utils.cpp
src/detail/message_type_support.cpp
src/detail/rmw_data_types.cpp
src/detail/service_type_support.cpp
Expand Down
Loading

0 comments on commit 1bfc2c1

Please sign in to comment.