Bugfix: Update metadata with new file_info before saving it the first time in the file #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelOrlov
requested review from
emersonknapp,
jhdcs,
christophebedard and
fujitatomoya
and removed request for
a team,
emersonknapp and
jhdcs
|
@ros-pull-request-builder retest this please |
christophebedard
approved these changes
Oct 31, 2024
Signed-off-by: Michael Orlov <[email protected]>
MichaelOrlov
force-pushed
the
morlov/update_metadata_before_saving
branch
from
4b35616 to
07e5672
Compare
|
Pulls: #1843
|
|
Something weird happened in that Windows job |
|
|
https://github.com/Mergifyio backport jazzy |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 4, 2024
#1843) Signed-off-by: Michael Orlov <[email protected]> (cherry picked from commit b5098ef)
MichaelOrlov
added a commit
that referenced
this pull request
Nov 7, 2024
#1843) (#1853) Signed-off-by: Michael Orlov <[email protected]> (cherry picked from commit b5098ef) Co-authored-by: Michael Orlov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a bug fix for missing file_info for newly created file in saved metadata.
When we are switching to new storage, the correct behavior shall be as follows: