Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase timeout to 180s for test_rosbag2_record_end_to_end #1889

Merged
merged 1 commit into from
Dec 28, 2024
Merged

Increase timeout to 180s for test_rosbag2_record_end_to_end #1889

merged 1 commit into from
Dec 28, 2024

Conversation

Yadunund
Copy link
Member

@Yadunund Yadunund commented Dec 27, 2024 •
edited by MichaelOrlov
Loading

This PR increases timeout to 180s for test_rosbag2_record_end_to_end.

Running the test with rmw_zenoh takes a bit longer since it takes a couple seconds to initialize the ROS context. With this change, I was able to get the test to pass.

@Yadunund Yadunund requested a review from clalancette December 27, 2024 22:58
fujitatomoya
fujitatomoya approved these changes Dec 28, 2024
View reviewed changes
Copy link
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think that is okay. @MichaelOrlov what do you think?

MichaelOrlov
MichaelOrlov approved these changes Dec 28, 2024
View reviewed changes
Copy link
Contributor

@MichaelOrlov MichaelOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it helps to pass tests on CI with rmw_zenoh, I don't mind increasing test's timeout.

@MichaelOrlov MichaelOrlov merged commit bed1131 into rolling Dec 28, 2024
12 checks passed
@MichaelOrlov MichaelOrlov deleted the yadu/increase_test_timeout branch December 28, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@MichaelOrlov MichaelOrlov MichaelOrlov approved these changes

@clalancette clalancette Awaiting requested review from clalancette

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yadunund @MichaelOrlov @fujitatomoya