include QString (#1298)

ros2 · Nov 13, 2024 · 9a94bdf · 9a94bdf
1 parent 0d95ae1
commit 9a94bdf
Show file tree

Hide file tree

Showing 203 changed files with 348 additions and 44 deletions.
diff --git a/rviz_common/include/rviz_common/display.hpp b/rviz_common/include/rviz_common/display.hpp
@@ -36,6 +36,7 @@
 
 #include <QIcon>  // NOLINT: cpplint is unable to handle the include order here
 #include <QSet>  // NOLINT: cpplint is unable to handle the include order here
+#include <QString>  // NOLINT: cpplint is unable to handle the include order here
 
 #include "rclcpp/time.hpp"
 

diff --git a/rviz_common/include/rviz_common/display_group.hpp b/rviz_common/include/rviz_common/display_group.hpp
@@ -32,6 +32,8 @@
 #ifndef RVIZ_COMMON__DISPLAY_GROUP_HPP_
 #define RVIZ_COMMON__DISPLAY_GROUP_HPP_
 
+#include <QString>
+
 #include "rviz_common/display.hpp"
 #include "rviz_common/visibility_control.hpp"
 

diff --git a/rviz_common/include/rviz_common/factory/class_id_recording_factory.hpp b/rviz_common/include/rviz_common/factory/class_id_recording_factory.hpp
@@ -32,6 +32,8 @@
 #ifndef RVIZ_COMMON__FACTORY__CLASS_ID_RECORDING_FACTORY_HPP_
 #define RVIZ_COMMON__FACTORY__CLASS_ID_RECORDING_FACTORY_HPP_
 
+#include <QString>
+
 #include "./factory.hpp"
 
 namespace rviz_common

diff --git a/rviz_common/include/rviz_common/message_filter_display.hpp b/rviz_common/include/rviz_common/message_filter_display.hpp
@@ -35,6 +35,8 @@
 #include <memory>
 #include <string>
 
+#include <QString>  // NOLINT: cpplint is unable to handle the include order here
+
 #include <message_filters/subscriber.hpp>
 
 #include "rviz_common/ros_topic_display.hpp"

diff --git a/rviz_common/include/rviz_common/panel.hpp b/rviz_common/include/rviz_common/panel.hpp
@@ -33,6 +33,7 @@
 #ifndef RVIZ_COMMON__PANEL_HPP_
 #define RVIZ_COMMON__PANEL_HPP_
 
+#include <QString>
 #include <QWidget>
 
 #include "rviz_common/config.hpp"

diff --git a/rviz_common/include/rviz_common/panel_dock_widget.hpp b/rviz_common/include/rviz_common/panel_dock_widget.hpp
@@ -34,6 +34,7 @@
 
 #include <QDockWidget>
 #include <QLabel>
+#include <QString>
 
 #include "rviz_common/config.hpp"
 #include "rviz_common/visibility_control.hpp"

diff --git a/rviz_common/include/rviz_common/properties/bool_property.hpp b/rviz_common/include/rviz_common/properties/bool_property.hpp
@@ -32,6 +32,8 @@
 #ifndef RVIZ_COMMON__PROPERTIES__BOOL_PROPERTY_HPP_
 #define RVIZ_COMMON__PROPERTIES__BOOL_PROPERTY_HPP_
 
+#include <QString>
+
 #include "rviz_common/properties/property.hpp"
 #include "rviz_common/visibility_control.hpp"
 

diff --git a/rviz_common/include/rviz_common/properties/combo_box.hpp b/rviz_common/include/rviz_common/properties/combo_box.hpp
@@ -31,6 +31,7 @@
 #define RVIZ_COMMON__PROPERTIES__COMBO_BOX_HPP_
 
 #include <QComboBox>
+#include <QString>
 
 #include "rviz_common/visibility_control.hpp"
 

diff --git a/rviz_common/include/rviz_common/properties/covariance_property.hpp b/rviz_common/include/rviz_common/properties/covariance_property.hpp
@@ -38,6 +38,7 @@
 #include <OgreColourValue.h>
 
 #include <QColor>  // NOLINT cpplint cannot handle include order here
+#include <QString>  // NOLINT cpplint cannot handle include order here
 
 #include "rviz_common/properties/bool_property.hpp"
 #include "rviz_common/visibility_control.hpp"

diff --git a/rviz_common/include/rviz_common/properties/enum_property.hpp b/rviz_common/include/rviz_common/properties/enum_property.hpp
@@ -32,10 +32,11 @@
 #ifndef RVIZ_COMMON__PROPERTIES__ENUM_PROPERTY_HPP_
 #define RVIZ_COMMON__PROPERTIES__ENUM_PROPERTY_HPP_
 
-#include <QStringList>
-
 #include <string>
 
+#include <QString>  // NOLINT: cpplint is unable to handle the include order here
+#include <QStringList>  // NOLINT: cpplint is unable to handle the include order here
+
 #include "rviz_common/properties/string_property.hpp"
 #include "rviz_common/visibility_control.hpp"
 

diff --git a/rviz_common/include/rviz_common/properties/file_picker_property.hpp b/rviz_common/include/rviz_common/properties/file_picker_property.hpp
@@ -31,6 +31,8 @@
 #ifndef RVIZ_COMMON__PROPERTIES__FILE_PICKER_PROPERTY_HPP_
 #define RVIZ_COMMON__PROPERTIES__FILE_PICKER_PROPERTY_HPP_
 
+#include <QString>
+
 #include "rviz_common/properties/string_property.hpp"
 #include "rviz_common/visibility_control.hpp"
 

diff --git a/rviz_common/include/rviz_common/properties/float_property.hpp b/rviz_common/include/rviz_common/properties/float_property.hpp
@@ -32,6 +32,8 @@
 #ifndef RVIZ_COMMON__PROPERTIES__FLOAT_PROPERTY_HPP_
 #define RVIZ_COMMON__PROPERTIES__FLOAT_PROPERTY_HPP_
 
+#include <QString>
+
 #include "rviz_common/properties/property.hpp"
 #include "rviz_common/visibility_control.hpp"
 

diff --git a/rviz_common/include/rviz_common/properties/grouped_checkbox_property.hpp b/rviz_common/include/rviz_common/properties/grouped_checkbox_property.hpp
@@ -33,6 +33,8 @@
 
 #include <memory>
 
+#include <QString>  // NOLINT: cpplint is unable to handle the include order here
+
 #include "rviz_common/properties/bool_property.hpp"
 
 namespace rviz_common

diff --git a/rviz_common/include/rviz_common/properties/int_property.hpp b/rviz_common/include/rviz_common/properties/int_property.hpp
@@ -32,6 +32,8 @@
 #ifndef RVIZ_COMMON__PROPERTIES__INT_PROPERTY_HPP_
 #define RVIZ_COMMON__PROPERTIES__INT_PROPERTY_HPP_
 
+#include <QString>
+
 #include "rviz_common/properties/property.hpp"
 #include "rviz_common/visibility_control.hpp"
 

diff --git a/rviz_common/include/rviz_common/properties/property_tree_model.hpp b/rviz_common/include/rviz_common/properties/property_tree_model.hpp
@@ -33,6 +33,7 @@
 #define RVIZ_COMMON__PROPERTIES__PROPERTY_TREE_MODEL_HPP_
 
 #include <QAbstractItemModel>
+#include <QString>
 
 #include "rviz_common/visibility_control.hpp"
 

diff --git a/rviz_common/include/rviz_common/properties/property_tree_widget.hpp b/rviz_common/include/rviz_common/properties/property_tree_widget.hpp
@@ -33,6 +33,7 @@
 #define RVIZ_COMMON__PROPERTIES__PROPERTY_TREE_WIDGET_HPP_
 
 #include <QTreeView>
+#include <QString>
 
 #include "./property_tree_model.hpp"
 #include "rviz_common/config.hpp"

diff --git a/rviz_common/include/rviz_common/properties/quaternion_property.hpp b/rviz_common/include/rviz_common/properties/quaternion_property.hpp
@@ -33,6 +33,8 @@
 
 #include <OgreQuaternion.h>
 
+#include <QString>
+
 #include "rviz_common/properties/property.hpp"
 #include "rviz_common/visibility_control.hpp"
 

diff --git a/rviz_common/include/rviz_common/properties/regex_filter_property.hpp b/rviz_common/include/rviz_common/properties/regex_filter_property.hpp
@@ -30,14 +30,15 @@
 #ifndef RVIZ_COMMON__PROPERTIES__REGEX_FILTER_PROPERTY_HPP_
 #define RVIZ_COMMON__PROPERTIES__REGEX_FILTER_PROPERTY_HPP_
 
-#include <QValidator>
-#include <QLineEdit>
-#include <QToolTip>
-#include <QWidget>
-
 #include <regex>
 #include <string>
 
+#include <QValidator>  // NOLINT: cpplint is unable to handle the include order here
+#include <QLineEdit>  // NOLINT: cpplint is unable to handle the include order here
+#include <QString>  // NOLINT: cpplint is unable to handle the include order here
+#include <QToolTip>  // NOLINT: cpplint is unable to handle the include order here
+#include <QWidget>  // NOLINT: cpplint is unable to handle the include order here
+
 #include "rviz_common/properties/string_property.hpp"
 #include "rviz_common/visibility_control.hpp"
 

diff --git a/rviz_common/include/rviz_common/properties/ros_topic_property.hpp b/rviz_common/include/rviz_common/properties/ros_topic_property.hpp
@@ -32,6 +32,8 @@
 
 #include <string>
 
+#include <QString>  // NOLINT: cpplint is unable to handle the include order here
+
 #include "rviz_common/properties/editable_enum_property.hpp"
 #include "rviz_common/ros_integration/ros_node_abstraction_iface.hpp"
 #include "rviz_common/visibility_control.hpp"

diff --git a/rviz_common/include/rviz_common/properties/status_property.hpp b/rviz_common/include/rviz_common/properties/status_property.hpp
@@ -33,6 +33,7 @@
 #define RVIZ_COMMON__PROPERTIES__STATUS_PROPERTY_HPP_
 
 #include <QIcon>
+#include <QString>
 
 #include "rviz_common/properties/property.hpp"
 #include "rviz_common/visibility_control.hpp"

diff --git a/rviz_common/include/rviz_common/properties/string_property.hpp b/rviz_common/include/rviz_common/properties/string_property.hpp
@@ -34,6 +34,8 @@
 
 #include <string>
 
+#include <QString>  // NOLINT: cpplint is unable to handle the include order here
+
 #include "rviz_common/properties/property.hpp"
 #include "rviz_common/visibility_control.hpp"
 

diff --git a/rviz_common/include/rviz_common/properties/tf_frame_property.hpp b/rviz_common/include/rviz_common/properties/tf_frame_property.hpp
@@ -33,6 +33,9 @@
 #define RVIZ_COMMON__PROPERTIES__TF_FRAME_PROPERTY_HPP_
 
 #include <string>
+
+#include <QString>  // NOLINT: cpplint is unable to handle the include order here
+
 #include "rviz_common/frame_manager_iface.hpp"
 
 #include "./editable_enum_property.hpp"

diff --git a/rviz_common/include/rviz_common/properties/vector_property.hpp b/rviz_common/include/rviz_common/properties/vector_property.hpp
@@ -34,6 +34,8 @@
 
 #include <OgreVector.h>
 
+#include <QString>
+
 #include "rviz_common/properties/property.hpp"
 #include "rviz_common/visibility_control.hpp"
 

diff --git a/rviz_common/include/rviz_common/ros_topic_display.hpp b/rviz_common/include/rviz_common/ros_topic_display.hpp
@@ -40,6 +40,8 @@
 #include <OgreSceneNode.h>
 #include <OgreSceneManager.h>
 
+#include <QString>  // NOLINT: cpplint is unable to handle the include order here
+
 #endif
 
 #include "rclcpp/qos.hpp"

diff --git a/rviz_common/include/rviz_common/tool_manager.hpp b/rviz_common/include/rviz_common/tool_manager.hpp
@@ -37,6 +37,7 @@
 
 #include <QList>  // NOLINT: cpplint is unable to handle the include order here
 #include <QObject>  // NOLINT: cpplint is unable to handle the include order here
+#include <QString>  // NOLINT: cpplint is unable to handle the include order here
 #include <QStringList>  // NOLINT: cpplint is unable to handle the include order here
 
 #include "rviz_common/factory/pluginlib_factory.hpp"

diff --git a/rviz_common/include/rviz_common/view_manager.hpp b/rviz_common/include/rviz_common/view_manager.hpp
@@ -37,6 +37,7 @@
 
 #include <QList>  // NOLINT: cpplint is unable to handle the include order here
 #include <QObject>  // NOLINT: cpplint is unable to handle the include order here
+#include <QString>  // NOLINT: cpplint is unable to handle the include order here
 #include <QStringList>  // NOLINT: cpplint is unable to handle the include order here
 
 #include "rviz_common/properties/property.hpp"

diff --git a/rviz_common/include/rviz_common/visualization_manager.hpp b/rviz_common/include/rviz_common/visualization_manager.hpp
@@ -36,6 +36,8 @@
 #include <deque>
 #include <memory>
 
+#include <QString>  // NOLINT: cpplint is unable to handle the include order here
+
 #include "rclcpp/clock.hpp"
 #include "rclcpp/time.hpp"
 #include "tf2_ros/transform_listener.h"

diff --git a/rviz_common/include/rviz_common/visualizer_app.hpp b/rviz_common/include/rviz_common/visualizer_app.hpp
@@ -36,6 +36,7 @@
 
 #include <QApplication>  // NOLINT: cpplint is unable to handle the include order here
 #include <QObject>  // NOLINT: cpplint is unable to handle the include order here
+#include <QString>  // NOLINT: cpplint is unable to handle the include order here
 
 #include "rviz_common/ros_integration/ros_client_abstraction_iface.hpp"
 #include "rviz_common/visibility_control.hpp"

diff --git a/rviz_common/include/rviz_common/window_manager_interface.hpp b/rviz_common/include/rviz_common/window_manager_interface.hpp
@@ -33,6 +33,7 @@
 #define RVIZ_COMMON__WINDOW_MANAGER_INTERFACE_HPP_
 
 #include <Qt>
+#include <QString>
 
 class QWidget;
 class QString;

diff --git a/rviz_common/include/rviz_common/yaml_config_reader.hpp b/rviz_common/include/rviz_common/yaml_config_reader.hpp
@@ -34,6 +34,8 @@
 
 #include <istream>
 
+#include <QString>  // NOLINT: cpplint is unable to handle the include order here
+
 #include "rviz_common/config.hpp"
 #include "rviz_common/visibility_control.hpp"
 

diff --git a/rviz_common/include/rviz_common/yaml_config_writer.hpp b/rviz_common/include/rviz_common/yaml_config_writer.hpp
@@ -34,6 +34,8 @@
 
 #include <ostream>
 
+#include <QString>  // NOLINT: cpplint is unable to handle the include order here
+
 #include "rviz_common/config.hpp"
 #include "rviz_common/visibility_control.hpp"
 

diff --git a/rviz_common/src/rviz_common/add_display_dialog.cpp b/rviz_common/src/rviz_common/add_display_dialog.cpp
@@ -47,6 +47,7 @@
 #include <QLabel>  // NOLINT: cpplint is unable to handle the include order here
 #include <QLineEdit>  // NOLINT: cpplint is unable to handle the include order here
 #include <QPushButton>  // NOLINT: cpplint is unable to handle the include order here
+#include <QString>  // NOLINT: cpplint is unable to handle the include order here
 #include <QTabWidget>  // NOLINT: cpplint is unable to handle the include order here
 #include <QTextBrowser>  // NOLINT: cpplint is unable to handle the include order here
 #include <QVBoxLayout>  // NOLINT: cpplint is unable to handle the include order here

diff --git a/rviz_common/src/rviz_common/add_display_dialog.hpp b/rviz_common/src/rviz_common/add_display_dialog.hpp
@@ -39,6 +39,7 @@
 #include <QComboBox>  // NOLINT: cpplint is unable to handle the include order here
 #include <QDialog>  // NOLINT: cpplint is unable to handle the include order here
 #include <QMultiMap>  // NOLINT: cpplint is unable to handle the include order here
+#include <QString>  // NOLINT: cpplint is unable to handle the include order here
 #include <QTreeWidget>  // NOLINT: cpplint is unable to handle the include order here
 
 #include "rviz_common/factory/factory.hpp"

diff --git a/rviz_common/src/rviz_common/config.cpp b/rviz_common/src/rviz_common/config.cpp
@@ -32,6 +32,7 @@
 #include "rviz_common/config.hpp"
 
 #include <QLocale>
+#include <QString>
 
 namespace rviz_common
 {

diff --git a/rviz_common/src/rviz_common/display.cpp b/rviz_common/src/rviz_common/display.cpp
@@ -43,6 +43,7 @@
 #include <QFont>  // NOLINT: cpplint is unable to handle the include order here
 #include <QMetaObject>  // NOLINT: cpplint is unable to handle the include order here
 #include <QWidget>  // NOLINT: cpplint is unable to handle the include order here
+#include <QString>  // NOLINT: cpplint is unable to handle the include order here
 
 #include "rclcpp/time.hpp"
 #include "rclcpp/rclcpp.hpp"

diff --git a/rviz_common/src/rviz_common/display_factory.cpp b/rviz_common/src/rviz_common/display_factory.cpp
@@ -35,6 +35,8 @@
 
 #include <tinyxml2.h>  // NOLINT: cpplint is unable to handle the include order here
 
+#include <QString>  // NOLINT: cpplint is unable to handle the include order here
+
 #include "rviz_common/display_group.hpp"
 #include "rviz_common/logging.hpp"
 

diff --git a/rviz_common/src/rviz_common/display_group.cpp b/rviz_common/src/rviz_common/display_group.cpp
@@ -35,6 +35,7 @@
 #include <map>
 
 #include <QColor>  // NOLINT: cpplint is unable to handle the include order here
+#include <QString>  // NOLINT: cpplint is unable to handle the include order here
 
 #include "./display_factory.hpp"
 #include "./failed_display.hpp"

diff --git a/rviz_common/src/rviz_common/displays_panel.cpp b/rviz_common/src/rviz_common/displays_panel.cpp
@@ -39,6 +39,7 @@
 #include <QInputDialog>  // NOLINT: cpplint is unable to handle the include order here
 #include <QProgressDialog> // NOLINT: cpplint is unable to handle the include order here
 #include <QPushButton>  // NOLINT: cpplint is unable to handle the include order here
+#include <QString>  // NOLINT: cpplint is unable to handle the include order here
 #include <QTimer>  // NOLINT: cpplint is unable to handle the include order here
 #include <QVBoxLayout>  // NOLINT: cpplint is unable to handle the include order here
 

diff --git a/rviz_common/src/rviz_common/failed_display.cpp b/rviz_common/src/rviz_common/failed_display.cpp
@@ -32,6 +32,7 @@
 #include "failed_display.hpp"
 
 #include <QColor>  // NOLINT: cpplint is unable to handle the include order here
+#include <QString>  // NOLINT: cpplint is unable to handle the include order here
 
 #include "rviz_common/load_resource.hpp"
 #include "rviz_common/properties/status_property.hpp"

diff --git a/rviz_common/src/rviz_common/failed_display.hpp b/rviz_common/src/rviz_common/failed_display.hpp
@@ -32,6 +32,8 @@
 #ifndef RVIZ_COMMON__FAILED_DISPLAY_HPP_
 #define RVIZ_COMMON__FAILED_DISPLAY_HPP_
 
+#include <QString>
+
 #include "rviz_common/display.hpp"
 
 namespace rviz_common

diff --git a/rviz_common/src/rviz_common/failed_panel.cpp b/rviz_common/src/rviz_common/failed_panel.cpp
@@ -34,6 +34,7 @@
 #include <cstdio>
 
 #include <QHBoxLayout>  // NOLINT: cpplint is unable to handle the include order here
+#include <QString>  // NOLINT: cpplint is unable to handle the include order here
 #include <QTextBrowser>  // NOLINT: cpplint is unable to handle the include order here
 
 namespace rviz_common

diff --git a/rviz_common/src/rviz_common/failed_panel.hpp b/rviz_common/src/rviz_common/failed_panel.hpp
@@ -34,6 +34,8 @@
 
 #include <memory>
 
+#include <QString>  // NOLINT: cpplint is unable to handle the include order here
+
 #include "rviz_common/panel.hpp"
 
 namespace rviz_common

diff --git a/rviz_common/src/rviz_common/failed_tool.cpp b/rviz_common/src/rviz_common/failed_tool.cpp
@@ -32,6 +32,7 @@
 #include "failed_tool.hpp"
 
 #include <QMessageBox>
+#include <QString>
 
 #include "rviz_common/window_manager_interface.hpp"
 #include "rviz_common/display_context.hpp"

diff --git a/rviz_common/src/rviz_common/failed_view_controller.cpp b/rviz_common/src/rviz_common/failed_view_controller.cpp
@@ -32,6 +32,7 @@
 #include "failed_view_controller.hpp"
 
 #include <QMessageBox>
+#include <QString>
 
 #include "rviz_common/display_context.hpp"
 #include "rviz_common/window_manager_interface.hpp"