Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label DPs with cloud API descriptions if available #1256

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wgrant
Copy link

@wgrant wgrant commented Jan 20, 2023

The Tuya cloud Get Device Specification Attribute API provides a name for most DPs for most devices. When configuring a device, include that name if it's available.

Screenshot from 2023-01-21 10-48-51

The Tuya cloud Get Device Specification Attribute API provides
a name for most DPs for most devices. When configuring a device, include
that name if it's available.
Copy link

@CloCkWeRX CloCkWeRX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks quite useful.

@SamJongenelen
Copy link

Great!

@patrik-malina
Copy link

It could be quite useful

@CloCkWeRX
Copy link

Not sure if it's working on edit; tested via merging your branch into https://github.com/CloCkWeRX/localtuya-experimental

When I edit an existing device; I see:

image

No relevant failures in the logs, so either it's not being invoked via edit or I've done something wrong when deploying. Fairly confident these DPs would be labelled

@wgrant
Copy link
Author

wgrant commented Jan 23, 2023

Not sure if it's working on edit

The DP strings (previously including values, and now including names) are cached for existing devices -- grep for CONF_DPS_STRINGS. I don't know of an existing way to invalidate this cache other than manually removing the dps_strings values from core.config_entries.

@CloCkWeRX
Copy link

Alright, much happier now:
image

This makes life significantly easier!
Potentially could self configure some DPs if the naming is 1:1 automagically; or detect platform.

@CloCkWeRX
Copy link

@rospogrigio after you land the stability fixes, I feel like this one is a good feature to include. Tested locally; seems happy.

PaulCavill pushed a commit to PaulCavill/localtuya that referenced this pull request Sep 4, 2023
@darth-hp
Copy link

darth-hp commented Feb 6, 2024

Wish to have this merged please

@vrioux
Copy link

vrioux commented Feb 6, 2024

I logged in just to say this would have helped me a lot. Any reviewer able to merge it?

@rospogrigio
Copy link
Owner

No only I can merge it but I am having a super tough period, I'll do it as soon as I can.
Thank you for your understanding, bye

@darth-hp
Copy link

darth-hp commented Feb 6, 2024

Probably it's a good idea to allow other to chime into the project? With nearly 1000 issues and 100 pull requests there is a lot of demand and a lot of will to collaborate, right?

@darth-hp
Copy link

darth-hp commented May 6, 2024

@rospogrigio what's the missing ci for merging?

Copy link

@darth-hp darth-hp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants