-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Label DPs with cloud API descriptions if available #1256
base: master
Are you sure you want to change the base?
Conversation
The Tuya cloud Get Device Specification Attribute API provides a name for most DPs for most devices. When configuring a device, include that name if it's available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks quite useful.
Great! |
It could be quite useful |
Not sure if it's working on edit; tested via merging your branch into https://github.com/CloCkWeRX/localtuya-experimental When I edit an existing device; I see: No relevant failures in the logs, so either it's not being invoked via edit or I've done something wrong when deploying. Fairly confident these DPs would be labelled |
The DP strings (previously including values, and now including names) are cached for existing devices -- grep for CONF_DPS_STRINGS. I don't know of an existing way to invalidate this cache other than manually removing the dps_strings values from core.config_entries. |
@rospogrigio after you land the stability fixes, I feel like this one is a good feature to include. Tested locally; seems happy. |
Wish to have this merged please |
I logged in just to say this would have helped me a lot. Any reviewer able to merge it? |
No only I can merge it but I am having a super tough period, I'll do it as soon as I can. |
Probably it's a good idea to allow other to chime into the project? With nearly 1000 issues and 100 pull requests there is a lot of demand and a lot of will to collaborate, right? |
@rospogrigio what's the missing ci for merging? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The Tuya cloud Get Device Specification Attribute API provides a name for most DPs for most devices. When configuring a device, include that name if it's available.