ESC Setup / programming (bidirectional telemetry / forward programming) - implemented for HW5 ESCs #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…additional responses, pack param payload for MSP editor
…ols like HW5 that need to see the higher resolution timer
* master: Improve baro filtering defaults Improve rescue gain and time defaults
rotorflight
requested changes
May 16, 2024
src/main/sensors/esc_sensor.c
Outdated
| @@ -1986,8 +2218,9 @@ static bool tribDecode(timeMs_t currentTimeMs) | |||
| } | |||
| } | |||
|
|
|||
| static bool tribCrankUncSetup(timeMs_t currentTimeMs) | |||
| static bool tribCrankUncSetup(timeMs_t currentTimeUs) | |||
src/main/sensors/esc_sensor.c
Outdated
| typedef bool (*rrfsmStartCallbackPtr)(timeMs_t currentTimeMs); // return true to continue w/ default initialization (if in doubt return true) | ||
| typedef bool (*rrfsmDecodeCallbackPtr)(timeMs_t currentTimeMs); // return true if frame was decoded successfully | ||
| typedef bool (*rrfsmCrankCallbackPtr)(timeMs_t currentTimeMs); // return true to continue w/ default loop (advanced, if in doubt return true) | ||
| typedef bool (*rrfsmStartCallbackPtr)(timeMs_t currentTimeUs); // return true to continue w/ default initialization (if in doubt return true) |
src/main/sensors/esc_sensor.c
Outdated
| typedef bool (*rrfsmCrankCallbackPtr)(timeMs_t currentTimeMs); // return true to continue w/ default loop (advanced, if in doubt return true) | ||
| typedef bool (*rrfsmStartCallbackPtr)(timeMs_t currentTimeUs); // return true to continue w/ default initialization (if in doubt return true) | ||
| typedef bool (*rrfsmDecodeCallbackPtr)(timeUs_t currentTimeUs); // return true if frame was decoded successfully | ||
| typedef bool (*rrfsmCrankCallbackPtr)(timeMs_t currentTimeUs); // return true to continue w/ default loop (advanced, if in doubt return true) |
| } | ||
|
|
||
| static void pl5BuildNextReq() | ||
| { |
There was a problem hiding this comment.
SMH - give me a minute :)
There was a problem hiding this comment.
timeUs_t and fn(void) usage addressed
rotorflight
approved these changes
May 17, 2024
|
great - thanks |
bob01
added a commit
to bob01/rotorflight-firmware
that referenced
this pull request
Jun 5, 2024
* hd - pl5 - hw5 / pl5 ported to rrfsm * hd - pl5 - added: device info & get params req, extended decoder for additional responses, pack param payload for MSP editor * hd - pl5 - enter MSP editor from tele * hd - pl5 - added writeparams req, resp, err * ESC Setup - param - OOB status (restart needed) and device identification * hd - pl5 - added OOB restart + identification, cleanup * pl5 - pre-pr code cosmetics, removed deprecated hw5 * pl5 - rrfsm - change callbacks to accept Us (vs Ms) to support protocols like HW5 that need to see the higher resolution timer * pl5 - more pre-pr code cosmetics, removed debug/test * pl5 - pr - timeUs_t and fn(void) usage addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESC setup / programming (forward programming) using the Tx via bidirectional telemetry #101
Complete for HobbyWing V5
Configuration
Code
HW5 support