feat: added MSP_PILOT_CONFIG with user definable parameters #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rotorflight
requested changes
Sep 6, 2024
There is no MSP_NAME bug, just a poor implementation. Added new MSP_PILOT_CONFIG messages instead of trying to reuse MSP_NAME. - as discussed. |
This reverts commit 52237ee.
|
This PR now also fixes the MSP_NAME bug by reverting commit 52237ee. |
rotorflight
reviewed
Sep 9, 2024
rotorflight
requested changes
Sep 9, 2024
|
Thanks again, fixed! |
rotorflight
approved these changes
Sep 11, 2024
bob01
added a commit
to bob01/rotorflight-firmware
that referenced
this pull request
Sep 17, 2024
…mware into esc_sensor_fly * 'master' of ssh://github.com/rotorflight/rotorflight-firmware: Fix HPF bug and cross-coupling scale (rotorflight#158) feat: add MSP_PILOT_CONFIG with user definable parameters (rotorflight#156) Use HPF instead of derivative in Cyclic Cross-Coupling Add firstOrderHPF in filter.c Improved PID defaults (rotorflight#140) Refactor RC response & acceleration filter (rotorflight#153)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is that there will also be a Model page (in Lua/Configurator) where the user can define up to 3 parameters. Those parameters will then be set in rf2bg.lua.