Add Graupner ESC telemetry support #174
Conversation
src/main/sensors/esc_sensor.c
Outdated
| rrfsmMinFrameLength = GRAUPNER_MIN_FRAME_LENGTH; | ||
| rrfsmAccept = graupnerAccept; | ||
| rrfsmDecode = graupnerDecode; | ||
| rrfsmCrank = NULL; |
There was a problem hiding this comment.
rrfsmCrank is initialized to NULL + *SensorInit(...) is called once - no harm but initialization here not necessary
src/main/sensors/esc_sensor.c
Outdated
| case ESC_SENSOR_PROTO_GRAUPNER: | ||
| callback = graupnerSensorInit(); | ||
| baudrate = 19200; | ||
| options |= SERIAL_BIDIR; |
There was a problem hiding this comment.
SERIAL_BIDIR option is a function of config->halfDuplex and is already set if configured
... but this protocol appears to function only in request/response mode making half duplex (or full duplex w/ tx/rx) required.
Choices...
- force half duplex operation ON here (now port state does not match port config - may create issues elsewhere)
- enforce config->halfDuplex on setting config->protocol and fail the init (return false if not config->halfDuplex) as a sanity check? (a bit more effort but feels more robust)
There was a problem hiding this comment.
I had the second option first, but then I thought what's the point there are no choices here. Why do we want the user to play roulette with it.
There was a problem hiding this comment.
The right thing is to set use the validateAndFixConfig routine and change the halfDuplex to true if Graupner is selected.
I'll fix this.
No description provided.