-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPS-98836 #1447
base: master
Are you sure you want to change the base?
LPS-98836 #1447
Conversation
…ts based on keyword searches
…ed is an object, and the receiving code is expecting an array
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
Just started reviewing :) |
6950495
to
eeaa3ae
Compare
Hey Ray, But, as far as your question earlier regarding where So, there are two questions I'm still looking at, which is where this data is being populated, but then also, how to pass the options along from the onChange handler. The flow of that data is still eluding me (basically, we could pass the category titles in the event object from the selected item in the vocabulary selector page, and not have to do an ajax request, but once it gets to that handler, I can't seem to find the connection between where that data is being pushed to make it's way to the render method of the component. I'll keep digging and update this if I find anything tonight :) |
Just started reviewing :) |
e914e3d
to
726fc07
Compare
726fc07
to
9627691
Compare
316b9b2
to
d73cd26
Compare
Miss you dude, and I think about you all the time. |
Same here |
Heya Ray, okay, on the code change, it doesn't appear to be much, but there was quite a bit of changes before getting to this point, and I'm still not 100% it's the proper way to fix it, but it seemed like our inputs were the only consumer of the vocabulary selector. So, the issue I was having was basically, what should be visible in the input both when displaying and when not editing. But if you let me know what's still missing for it, I can help out in any way you need.
Thanks Ray!