Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-98836 #1447

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

natecavanaugh
Copy link

Heya Ray, okay, on the code change, it doesn't appear to be much, but there was quite a bit of changes before getting to this point, and I'm still not 100% it's the proper way to fix it, but it seemed like our inputs were the only consumer of the vocabulary selector. So, the issue I was having was basically, what should be visible in the input both when displaying and when not editing. But if you let me know what's still missing for it, I can help out in any way you need.
Thanks Ray!

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@rotty3000
Copy link
Owner

Just started reviewing :)

:octocat: Sent from GH.

@natecavanaugh
Copy link
Author

natecavanaugh commented Oct 31, 2019

Hey Ray,
So I just pushed up a POC for you to check out. Basically, I'm hacking in the options if the value is set at all, but this is to just show what it should look like when it is working (and you can hard code whatever options you need to in there for now).

But, as far as your question earlier regarding where multiple is being set, while I still don't know for sure, I believe it might be coming in from the backend. If you view source of the page, you'll see that the configuration object is passed into the constructor, which includes multiple: true and multiple: false for different fields. And from what I can tell, this is coming from edit_segments_entry.jsp, the data coming in from this line:
<%= editSegmentsEntryDisplayContext.getData() %>

So, there are two questions I'm still looking at, which is where this data is being populated, but then also, how to pass the options along from the onChange handler. The flow of that data is still eluding me (basically, we could pass the category titles in the event object from the selected item in the vocabulary selector page, and not have to do an ajax request, but once it gets to that handler, I can't seem to find the connection between where that data is being pushed to make it's way to the render method of the component. I'll keep digging and update this if I find anything tonight :)

@rotty3000
Copy link
Owner

Just started reviewing :)

:octocat: Sent from GH.

@rotty3000
Copy link
Owner

Miss you dude, and I think about you all the time.

@brunobasto
Copy link

Miss you dude, and I think about you all the time.

Same here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants