Use composer InstalledRepository to determine install dir #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
commented
Apr 20, 2024
Comment on lines
+24
to
+28
| $rootPackage = clone $this->composer->getPackage(); | ||
| $installedRepo = new InstalledRepository([ | ||
| $installedRepo, | ||
| new RootPackageRepository($rootPackage), | ||
| ]); |
There was a problem hiding this comment.
FYI: inspired by https://github.com/composer/composer/blob/2.7.3/src/Composer/Command/CheckPlatformReqsCommand.php#L77 which clones the root package, /wo clone, an exception is thrown
mvorisek
force-pushed
the
honor_composer_replace
branch
2 times, most recently
from
9cea9e5
to
4d88b79
Compare
mvorisek
force-pushed
the
honor_composer_replace
branch
from
75ba177
to
8c74725
Compare
mvorisek
force-pushed
the
honor_composer_replace
branch
from
fcb0f3d
to
d66380f
Compare
|
@alecpl can this this PR me merged and tagged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on composer/composer#11927 (comment) recommendation
Original
$this->composer->getRepositoryManager()was wrong, as it searched all composer packages, not only the installed ones ignoring replace/provide composer options leading to possibly wrong path in theory.I tested installing this installer in Roundcubemail (as composer root package) manually and all went right.