Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct cost aggregation logic to resolve diff in monthly cost #21

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Correct cost aggregation logic to resolve diff in monthly cost #21

merged 3 commits into from
Jun 14, 2024
+211 −6

Conversation

Rindrics
Copy link
Collaborator

fix #8

@Rindrics Rindrics self-assigned this Jun 13, 2024
@Rindrics Rindrics requested a review from a team June 13, 2024 09:54
@Rindrics Rindrics force-pushed the issue-8-fix-cost-aggregation-logic branch from 941c5d2 to 2d9a375 Compare June 13, 2024 09:59
bvlion
bvlion approved these changes Jun 13, 2024
View reviewed changes
Copy link

@bvlion bvlion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the situation. It's a difficult issue. Since the tests are passing, I think it's fine.

Base automatically changed from issue-7-specify-accounts to main June 14, 2024 09:56
@Rindrics Rindrics merged commit 38dc2f3 into main Jun 14, 2024
1 check passed
@Rindrics Rindrics deleted the issue-8-fix-cost-aggregation-logic branch June 14, 2024 09:56
This was referenced Jun 14, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvlion bvlion bvlion approved these changes

Assignees

@Rindrics Rindrics

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modify cost aggregation logic
2 participants
@Rindrics @bvlion