Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to choose aggregation unit for Breakdown by service #22

Merged
merged 9 commits into from
Jun 14, 2024

Conversation

Rindrics
Copy link
Collaborator

resolve #9

@Rindrics Rindrics requested a review from a team June 13, 2024 10:00
@Rindrics Rindrics self-assigned this Jun 13, 2024
Copy link

@bvlion bvlion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@@ -18,7 +19,7 @@ $(BUILD_DIR): $(SRC_FILES) $(NODE_MODULES)
build: $(BUILD_DIR)

run: build
node ./bin/index.js --profile "${AWS_PROFILE}" --access-key "${ACCESS_KEY}" --secret-key "${SECRET_KEY}" --role-arn "${ROLE_ARN}" --region "${AWS_REGION}" -S $(SLACK_TOKEN_AWS_COST_CLI) -C $(SLACK_CHANNEL_ID)
node ./bin/index.js --profile "${AWS_PROFILE}" --access-key "${ACCESS_KEY}" --secret-key "${SECRET_KEY}" --role-arn "${ROLE_ARN}" --region "${AWS_REGION}" -S "${SLACK_TOKEN_AWS_COST_CLI}" -C "${SLACK_CHANNEL_ID}" --breakdown-period "${BREAKDOWN_PERIOD}"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Rindrics Rindrics force-pushed the issue-9-aggregation-unit branch from 803691a to 87083ae Compare June 14, 2024 03:17
Base automatically changed from issue-8-fix-cost-aggregation-logic to main June 14, 2024 09:56
@Rindrics Rindrics merged commit fdff859 into main Jun 14, 2024
2 checks passed
@Rindrics Rindrics deleted the issue-9-aggregation-unit branch June 14, 2024 09:57
This was referenced Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow specifying the aggregation unit for 'Breakdown by service' in Slack notifications
2 participants