1inn 160 #3
Open
1inn 160 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The maintenance badge leads to https://gist.github.com/cheerfulstoic/d107229326a01ff0f333a1d3476e068d _Actively Maintained_ is described there as > The maintainer(s) of this project are responding to issues and integrating code contributions ...which should set the correct expectations for people stumbling upon. Not explicitly said, but I count that also means we'll be doing (minor, mostly) releases.
https://doc.rust-lang.org/std/fs/fn.read_dir.html already returns an Iterator (`ReadDir`s IntoIter implementation returns `self`)
The recommended netlink buffer size is based on the system's page size, which means that the current size is far too small for systems with 16k or 64k pages, such as Asahi Linux or RHEL's kernel-64k for ARM64. On these systems, the server fails to start with errors like this: Error: Decode error occurred: invalid netlink buffer: length field says 1444 the buffer is 1260 bytes long Instead, follow the kernel's own netlink docs to compute the buffer size. The approach here matches the approach merged into Chromium recently: https://chromium-review.googlesource.com/c/chromium/src/+/4312885
…oint candidates (tonarino#262) * Add a missing call to reset a peer's endpoint when NAT traversal fails to connect to any endpoint candidates * Simplify the process of resetting a peer to its server-reported endpoint
* Turn ChangeString into a PeerChange enum, don't print NAT traversal reattempt as a modification * Remove the ChangeString type * Fix a stupid copy-paste error
* update netlink-*, toml, clap, other small dependencies * switch back to x25519-dalek from curve25519-dalek
* hostsfile: change internal map from hash to btree This change makes the innernet section of /etc/hosts always ordered and deterministic. We can take advantage of that to avoid writes, that will be done in another commit. * hostsfile: reduce number of writes if content hasn't changed * hostsfile: return bool to inform if file has been written This commit also makes the logs print accordingly to the new behavior. * hostsfile: remove has_content_changed in favor of comparing old and new sections * hostsfile: print the correct hosts path in log message * hostsfile: remove unnecessary intermediate variable
Follow-up to just-merged tonarino#175. We no longer install the `inn` symlink, so users doing that manually should know what they are doing.
…narino#267) * meta: add Brian, Ryo, Matěj as authors, canonicalize Jake's email Follow-up to tonarino#252. * Also update shared/Cargo.toml Co-authored-by: Jake McGinty <[email protected]> --------- Co-authored-by: Jake McGinty <[email protected]>
* meta: release v1.6.0 * README: update release steps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.