get_dnf5_cmd: Do not set "reposdir" and "config_file_path" #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are taken from installroot by default. Setting it explicitly via the CLI will hide the default behavior. And it changes the behavior if dnf.conf is not present.
|
Created a follow-up issue to address this automatic overriding of parameters in CI scenarios generally: #1468. |
|
All tests passed locally. Here one test failed - Scenario: using mirror wihtout ranges supports and zchunk results in only two GET requests for primary (the first try is with range specified). |
|
The scenario passes with older librepo (when built without commit rpm-software-management/librepo@66c99da ), so the failure seems independent on this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are taken from installroot by default.
Setting it explicitly via the CLI will hide the default behavior. And it changes the behavior if dnf.conf is not present.
Moreover, it is more compatible with DNF4 tests.
get_dnf4_cmddoes not set "reposdir" and "config_file_path".