test and fix for LOGSTASH-2288

rremer · Sep 23, 2014 · 01e9f37 · 01e9f37
1 parent 9c16d78
commit 01e9f37
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 5 deletions.
diff --git a/lib/logstash/config/config_ast.rb b/lib/logstash/config/config_ast.rb
@@ -74,10 +74,7 @@ def compile
         # defines @filter_func and @output_func
 
         definitions << "@#{type}_func = lambda do |event, &block|"
-        if type == "filter"
-          definitions << "  events = [event]"
-        end
-
+        definitions << "  events = [event]"
         definitions << "  @logger.debug? && @logger.debug(\"#{type} received\", :event => event.to_hash)"
         sections.select { |s| s.plugin_type.text_value == type }.each do |s|
           definitions << s.compile.split("\n", -1).map { |e| "  #{e}" }

diff --git a/spec/conditionals/test.rb b/spec/conditionals/test.rb
@@ -21,7 +21,32 @@ def conditional(expression, &block)
   end
 end
 
-describe "conditionals" do
+describe "conditionals in output" do
+  extend LogStash::RSpec
+  extend ConditionalFanciness
+
+  describe "simple" do
+    config <<-CONFIG
+      input {
+        generator {
+          message => '{"foo":{"bar"},"baz": "quux"}'
+          count => 1
+        }
+      }
+      output {
+        if [foo] == "bar" {
+          stdout { }
+        }
+      }
+    CONFIG
+
+    agent do
+      #LOGSTASH-2288, should not fail raising an exception
+    end
+  end
+end
+
+describe "conditionals in filter" do
   extend LogStash::RSpec
   extend ConditionalFanciness