Target netstandard1.6 and net45 #10
Conversation
Copied from the package version 0.4.0.
|
You are the man. Thank you so much for doing this and especially for including all the Also, this made me realize that I never backed up my own .snk and in fact had changed hard drives since the last time I did any open source work. The only drive with my .snk on it was sitting on my desk getting beverages spilled on it. So thanks for reminding me to pull that off of there! |
|
My pleasure! I learned something in the process, too, namely how to pin the FSharp.Core package version. The current doctrine regarding the SNK is just create one per open-source project and check it in. The signature is no longer relied upon for security, but allows the DLL to have a strong name.: Warning Do not rely on strong names for security. They provide a unique identity only.
There are interesting effects of changing the key, but if it's gone, it's gone. Basically, new key means new "full name", which means the build cannot create a binding redirect to consolidate references to one single version of the assembly (it is considered an entirely different assembly), but the two fight for the same file name in the bin/ output. I do not think many people are using this particular library to experience major unification problems; compare this and that. And all this can happen only if A.EXE refers to both B.DLL and your library nuget e. g. ver. 0.3.1, and B.DLL is in turn built against ver. 42.0 with a different key, for some value of 42. We (meaning the users of it) will survive. :) There is also this new PublicSign aka "fake sign" mechanism which, I believe, requires an SNK with a public key only. But I do not know much else except that it exists. By the way, AssemblyInfo.{cs,vb,fs} is no longer necessary too (you still have version 0.4.0 there). If you do not set the version attributes, the build will generate one in a temp directory and compile it in, setting all 3 version fields to the package version from the Love the |
Hit a couple snags, of course.
Targeting F# core package 4.2.3, since 4.2.* is the lowest version supporting netstandard.
I also resurrected generation of XML doc files, they were in the 0.3.1 package.
Tests out good:
Release packaging (requires the SNK file)
Make sure the right FSharp.Core version 4.2.3 is really used.
Package contents and dependencies look reasonable, too.
c:\projects\FParsec-Pipes>unzip -l FParsec-Pipes\bin\Release\FParsec-Pipes.1.1.0.nupkg Archive: FParsec-Pipes\bin\Release\FParsec-Pipes.1.1.0.nupkg Length Date Time Name --------- ---------- ----- ---- 507 2018-10-16 20:13 _rels/.rels 1578 2018-10-16 20:13 FParsec-Pipes.nuspec 200704 2018-10-17 03:13 lib/net45/FParsec-Pipes.dll 12028 2018-10-17 03:13 lib/net45/FParsec-Pipes.xml 201216 2018-10-17 03:13 lib/netstandard1.6/FParsec-Pipes.dll 12028 2018-10-17 03:13 lib/netstandard1.6/FParsec-Pipes.xml 528 2018-10-16 20:13 [Content_Types].xml 683 2018-10-16 20:13 package/services/metadata/core-properties/a079646db21a4b81837eb9bd62131c5f.psmdcp --------- ------- 429272 8 files c:\projects\FParsec-Pipes>unzip -p FParsec-Pipes\bin\Release\FParsec-Pipes.1.1.0.nupkg FParsec-Pipes.nuspec <?xml version="1.0" encoding="utf-8"?> <package xmlns="http://schemas.microsoft.com/packaging/2013/05/nuspec.xsd"> <metadata> <id>FParsec-Pipes</id> <version>1.1.0</version> <authors>Robert Peele</authors> <owners>Robert Peele</owners> <requireLicenseAcceptance>false</requireLicenseAcceptance> <licenseUrl>https://opensource.org/licenses/MIT</licenseUrl> <projectUrl>https://github.com/rspeele/FParsec-Pipes</projectUrl> <description>Package Description</description> <releaseNotes>Target netstandard1.6 and net45</releaseNotes> <copyright>Copyright 2016 Robert Peele</copyright> <tags>parser combinator f# fsharp c# csharp parsec fparsec pipe pipes</tags> <repository url="https://github.com/rspeele/FParsec-Pipes" /> <dependencies> <group targetFramework=".NETFramework4.5"> <dependency id="FParsec" version="1.0.3" exclude="Build,Analyzers" /> <dependency id="FSharp.Core" version="4.2.3" exclude="Build,Analyzers" /> <dependency id="System.ValueTuple" version="4.4.0" exclude="Build,Analyzers" /> </group> <group targetFramework=".NETStandard1.6"> <dependency id="FParsec" version="1.0.3" exclude="Build,Analyzers" /> <dependency id="FSharp.Core" version="4.2.3" exclude="Build,Analyzers" /> <dependency id="NETStandard.Library" version="1.6.1" exclude="Build,Analyzers" /> <dependency id="System.ValueTuple" version="4.4.0" exclude="Build,Analyzers" /> </group> </dependencies> </metadata> </package>Closes #9