chore: Error if ... includes unused options

rstudio · Dec 2, 2024 · 01a273c · 01a273c
1 parent b163ffa
commit 01a273c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/R/navs-legacy.R b/R/navs-legacy.R
@@ -216,6 +216,8 @@ navbar_options <- function(
     underline = missing(underline)
   )
 
+  rlang::check_dots_empty()
+
   opts <- list(
     position = rlang::arg_match(position),
     bg = bg,

diff --git a/tests/testthat/test-navs-legacy.R b/tests/testthat/test-navs-legacy.R
@@ -20,6 +20,10 @@ test_that("navbar_options() print method", {
   )
 })
 
+test_that("navbar_options() errors if ... swallows unused options", {
+  expect_error(navbar_options(foo = "bar"))
+})
+
 test_that("navbar_options_resolve_deprecated() consolidates correctly", {
   # TODO-deprecated: Remove when direction options are deprecated with an error