Undo margin-bottom where appropiate when the parent of a dynamic UI s…

…lot is a gap-spacing context (#993) * Close #992. Undo margin-bottom where appropiate when the parent of a dynamic UI slot is a gap-spacing context * Update news * Resave distributed files (GitHub Action) * Resave data (GitHub Action) * touch news * Resave distributed files (GitHub Action) --------- Co-authored-by: cpsievert <[email protected]>
rstudio · Feb 27, 2024 · de30e53 · de30e53
1 parent 469b36a
commit de30e53
Show file tree

Hide file tree

Showing 10 changed files with 10 additions and 3 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -32,6 +32,7 @@
 
 * Fixed an issue where the page might be given a window title of `NA` if the primary `title` argument of a page function, such as `page_sidebar()`, is `NULL` or a suitable window title could not be inferred. (#933)
 
+* `uiOutput()` no longer yields unwanted double padding when it's parent container uses `gap` for spacing multiple elements (e.g., `layout_columns()`, `page_fillable()`, etc). (#992)
 
 # bslib 0.6.1
 

diff --git a/R/sysdata.rda b/R/sysdata.rda
diff --git a/inst/bslib-scss/spacer.scss b/inst/bslib-scss/spacer.scss
@@ -23,6 +23,12 @@ $spacer: 1rem !default;
   > .bslib-mb-spacing, > .form-group, > p, > pre {
     margin-bottom: 0;
   }
+  // Make sure to get similar behavior in a uiOutput()/renderUI() context 
+  > .shiny-html-output {
+    > .bslib-mb-spacing, > .form-group, > p, > pre {
+      margin-bottom: 0;
+    }
+  }
 }
 
 // We generally don't want mb spacing for _activated_ fill items

diff --git a/inst/css-precompiled/3/bootstrap.min.css b/inst/css-precompiled/3/bootstrap.min.css
diff --git a/inst/css-precompiled/4/bootstrap.min.css b/inst/css-precompiled/4/bootstrap.min.css
diff --git a/inst/css-precompiled/5/bootstrap.min.css b/inst/css-precompiled/5/bootstrap.min.css
diff --git a/inst/fonts/HI_jiYsKILxRpg3hIP6sJ7fM7PqlOPHYvDP_W9O7GQTTbI1rSg.woff b/inst/fonts/HI_jiYsKILxRpg3hIP6sJ7fM7PqlOPHYvDP_W9O7GQTTbI1rSg.woff
diff --git a/inst/fonts/JTUHjIg1_i6t8kCHKm4532VJOt5-QNFgpCuM70w9.woff b/inst/fonts/JTUHjIg1_i6t8kCHKm4532VJOt5-QNFgpCuM70w9.woff
diff --git a/inst/fonts/UcCO3FwrK3iLTeHuS_fvQtMwCp50KnMw2boKoduKmMEVuI6fMZs.woff b/inst/fonts/UcCO3FwrK3iLTeHuS_fvQtMwCp50KnMw2boKoduKmMEVuI6fMZs.woff
diff --git a/inst/fonts/memQYaGs126MiZpBA-UFUIcVXSCEkx2cmqvXlWq8tWZ0Pw86hd0RkyFjaVQ.woff b/inst/fonts/memQYaGs126MiZpBA-UFUIcVXSCEkx2cmqvXlWq8tWZ0Pw86hd0RkyFjaVQ.woff
Original file line number	Diff line number	Diff line change
Expand Up		@@ -32,6 +32,7 @@

		* Fixed an issue where the page might be given a window title of `NA` if the primary `title` argument of a page function, such as `page_sidebar()`, is `NULL` or a suitable window title could not be inferred. (#933)

		* `uiOutput()` no longer yields unwanted double padding when it's parent container uses `gap` for spacing multiple elements (e.g., `layout_columns()`, `page_fillable()`, etc). (#992)

		# bslib 0.6.1

Expand Down