Skip to content

Commit

Permalink
feat!(navbars): Don't use BS3 compat for navbars in BS5+
Browse files Browse the repository at this point in the history
  • Loading branch information
gadenbuie committed Dec 4, 2024
1 parent ecd2137 commit fd2e808
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions R/bs-theme-preset-bootswatch.R
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,14 @@ bootswatch_bundle <- function(bootswatch, version) {
# Use local fonts (this path is relative to the bootstrap HTML dependency dir)
'$web-font-path: "font.css" !default;',
bootswatch_sass_file(bootswatch, "variables", version),
# Unless we change navbarPage()'s markup, BS4+ will likely want BS3 compatibility
# BS4 navbars are matched with BS3 for compatibility
switch_version(
version, three = "", default = bs3compat_navbar_defaults(bootswatch)
version,
three = "",
four = bs3compat_navbar_defaults(bootswatch),
# BS5 uses more neutral defaults (navbar that flips in light/dark mode)
# or requires a bit more user input
default = list()
)
),
rules = list(
Expand Down

0 comments on commit fd2e808

Please sign in to comment.