-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: navset_card_pills/tabs/underline now properly uses header & footer args #1028
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me. We have some more work to do in this area, but this is very clearly an improvement over the current state of affairs.
(@cpsievert: @tanho63 and I talked about this at Tidyverse Dev Day.)
@@ -52,10 +52,7 @@ navset_card_pill <- function( | |||
|
|||
items <- collect_nav_items(..., wrapper = wrapper) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: we should probably be differentiating between children and attributes and sending attributes to card()
. The other problem we might have here is that we should probably expose padding
and gap
options for the card we're creating but this is complicated by the fact that users can give padding
and gap
etc to nav_panel()
.
@tanho63 would you like to update this PR with |
@gadenbuie merged in latest main and fixed NEWS.md 😀 |
Thanks @tanho63! |
Closes #1024