Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shiny type update #1054

Merged
merged 6 commits into from
Jul 26, 2024
Merged

Shiny type update #1054

merged 6 commits into from
Jul 26, 2024

Conversation

wch
Copy link
Collaborator

@wch wch commented May 24, 2024 •
edited
Loading

This updates the types for rstudio/shiny to use the version from rstudio/shiny#4063.

Note that this required a change to some types in _utils.ts, but this does not affect any generated JS files.

  • After the Shiny PR is merged, update package.json her to use rstudio/shiny#main and re-run yarn to update yarn.lock.

@wch wch mentioned this pull request May 24, 2024
Merged
@wch wch force-pushed the shiny-type-update branch from 47bacfc to 75ebe81 Compare May 30, 2024 18:15
@wch wch force-pushed the shiny-type-update branch from 90e7c40 to 910f764 Compare July 26, 2024 20:15
@wch wch marked this pull request as ready for review July 26, 2024 20:15
gadenbuie
gadenbuie approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@gadenbuie gadenbuie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gadenbuie gadenbuie merged commit 65c1fe9 into main Jul 26, 2024
1 check passed
@gadenbuie gadenbuie deleted the shiny-type-update branch July 26, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadenbuie gadenbuie gadenbuie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wch @gadenbuie