Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Introduce navbar_options() #1141

Merged
merged 34 commits into from
Dec 2, 2024
Merged
Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
01ff848
chore: code style
gadenbuie Nov 26, 2024
9ed36bb
feat!(navbar_options): Introduce `navbar_options()`, deprecate navbar…
gadenbuie Nov 26, 2024
0612d30
feat: Add `underline` to `navbar_options()`
gadenbuie Nov 26, 2024
c726c6b
feat!(page_navbar): Use `navbar_options()`
gadenbuie Nov 26, 2024
284d10f
docs: Move `navbar_options()` to its own docs page
gadenbuie Nov 26, 2024
8abc2b7
chore(page_navbar): Move deprecated arguments to the end
gadenbuie Nov 26, 2024
388720b
docs: Update navset examples
gadenbuie Nov 26, 2024
33732ae
Resave data (GitHub Action)
gadenbuie Nov 26, 2024
f24c0c6
feat: Prevent deprecation warnings from `shiny::navbarPage()`
gadenbuie Nov 26, 2024
43e01c6
chore: small edits/fixes
gadenbuie Nov 26, 2024
15c42d4
chore: only warn if values are different
gadenbuie Nov 26, 2024
85b282a
chore: restore legacy code for minimal diff
gadenbuie Nov 26, 2024
a5b2868
chore(navbar_options): Expose defaults in function signature
gadenbuie Nov 27, 2024
5e1f0e2
Resave data (GitHub Action)
gadenbuie Nov 27, 2024
b017dc5
Update website deps (GitHub Action)
gadenbuie Nov 27, 2024
7d473ee
refactor: simplify navbar_options()
gadenbuie Nov 27, 2024
fcd6d5c
Revert "Update website deps (GitHub Action)"
gadenbuie Nov 27, 2024
3be0434
chore: use version 2 for internal data
gadenbuie Nov 27, 2024
bd43c4d
Resave data (GitHub Action)
gadenbuie Nov 27, 2024
a85ff8a
feat: Make `underline = TRUE` the default
gadenbuie Nov 27, 2024
0fc9985
chore: style
gadenbuie Nov 27, 2024
bf0f402
refactor: consolidate deprecation warning into single message
gadenbuie Nov 27, 2024
6f66bb7
tests: update snapshots
gadenbuie Nov 27, 2024
76a9692
`devtools::document()` (GitHub Actions)
gadenbuie Nov 27, 2024
60b84ce
docs: Add news item
gadenbuie Nov 27, 2024
3f0d9bd
docs: Add a note about `navset_bar()` in the examples page
gadenbuie Nov 27, 2024
7028fba
`devtools::document()` (GitHub Actions)
gadenbuie Nov 27, 2024
bc87599
chore: add todo note to remember to remove code when fully deprecated
gadenbuie Nov 27, 2024
cf8d423
chore: Include `...` for future expansion
gadenbuie Nov 27, 2024
ee683e7
refactor: Use attributes on `navbar_options()` to track source
gadenbuie Dec 2, 2024
b919ae6
chore: Apply changes from review
gadenbuie Dec 2, 2024
963a1eb
chore: edit wording in comment
gadenbuie Dec 2, 2024
b163ffa
feat: resolved navbar options equivalent to `navbar_options()`
gadenbuie Dec 2, 2024
01a273c
chore: Error if `...` includes unused options
gadenbuie Dec 2, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ S3method(is_fillable_container,default)
S3method(is_fillable_container,htmlwidget)
S3method(print,bslib_breakpoints)
S3method(print,bslib_fragment)
S3method(print,bslib_navbar_options)
S3method(print,bslib_page)
S3method(print,bslib_showcase_layout)
S3method(print,bslib_value_box_theme)
Expand Down Expand Up @@ -105,6 +106,7 @@ export(nav_remove)
export(nav_select)
export(nav_show)
export(nav_spacer)
export(navbar_options)
export(navs_bar)
export(navs_hidden)
export(navs_pill)
Expand Down
Loading
Loading