Skip to content

Commit

Permalink
Merge pull request #496 from rstudio/tylfin/ppm-unset-server-addr
Browse files Browse the repository at this point in the history
Fix: Unset the default [Server].Address option for PPM
  • Loading branch information
tylfin authored May 7, 2024
2 parents b9e7371 + 51cb74e commit 8e6c841
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 7 deletions.
2 changes: 1 addition & 1 deletion charts/rstudio-pm/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: rstudio-pm
description: Official Helm chart for RStudio Package Manager
version: 0.5.23
version: 0.5.24
apiVersion: v2
appVersion: 2024.04.0
icon: https://rstudio.com/wp-content/uploads/2018/10/RStudio-Logo-Flat.png
Expand Down
4 changes: 4 additions & 0 deletions charts/rstudio-pm/NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## 0.5.24

- Unset the `[Server].Address` default value as this can cause issues when serving from a domain name.

## 0.5.23

- Update default Posit Package Manager version to 2024.04.0-18
Expand Down
8 changes: 4 additions & 4 deletions charts/rstudio-pm/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Posit Package Manager

![Version: 0.5.23](https://img.shields.io/badge/Version-0.5.23-informational?style=flat-square) ![AppVersion: 2024.04.0](https://img.shields.io/badge/AppVersion-2024.04.0-informational?style=flat-square)
![Version: 0.5.24](https://img.shields.io/badge/Version-0.5.24-informational?style=flat-square) ![AppVersion: 2024.04.0](https://img.shields.io/badge/AppVersion-2024.04.0-informational?style=flat-square)

#### _Official Helm chart for RStudio Package Manager_

Expand All @@ -21,11 +21,11 @@ To ensure a stable production deployment, please:

## Installing the Chart

To install the chart with the release name `my-release` at version 0.5.23:
To install the chart with the release name `my-release` at version 0.5.24:

```bash
helm repo add rstudio https://helm.rstudio.com
helm upgrade --install my-release rstudio/rstudio-pm --version=0.5.23
helm upgrade --install my-release rstudio/rstudio-pm --version=0.5.24
```

To explore other chart versions, take a look at:
Expand Down Expand Up @@ -154,7 +154,7 @@ The Helm `config` values are converted into the `rstudio-pm.gcfg` service config
| awsAccessKeyId | bool | `false` | awsAccessKeyId is the access key id for s3 access, used also to gate file creation |
| awsSecretAccessKey | string | `nil` | awsSecretAccessKey is the secret access key, needs to be filled if access_key_id is |
| command | bool | `false` | command is the pod's run command. By default, it uses the container's default |
| config | object | `{"HTTP":{"Listen":":4242"},"Metrics":{"Enabled":true},"Server":{"Address":"http://localhost:4242"}}` | config is a nested map of maps that generates the rstudio-pm.gcfg file |
| config | object | `{"HTTP":{"Listen":":4242"},"Metrics":{"Enabled":true}}` | config is a nested map of maps that generates the rstudio-pm.gcfg file |
| enableMigration | bool | `true` | Enable migrations for shared storage (if necessary) using Helm hooks. |
| enableSandboxing | bool | `true` | Enable sandboxing of Git builds, which requires elevated security privileges for the Package Manager container. |
| extraContainers | list | `[]` | sidecar container list |
Expand Down
2 changes: 0 additions & 2 deletions charts/rstudio-pm/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -231,8 +231,6 @@ serviceMonitor:

# -- config is a nested map of maps that generates the rstudio-pm.gcfg file
config:
Server:
Address: http://localhost:4242
HTTP:
Listen: :4242
Metrics:
Expand Down

0 comments on commit 8e6c841

Please sign in to comment.