fix linter complaints, add ci tests, add makefile

charts/posit-chronicle/Chart.yaml

@@ -3,7 +3,6 @@ name: chronicle
 description: Helm chart for the Chronicle Server
 version: 0.1.0
 appVersion: 2023.11.0
-
 icon: https://rstudio.com/wp-content/uploads/2018/10/RStudio-Logo-Flat.png
 home: https://www.posit.co
 sources:

charts/posit-chronicle/Makefile

@@ -0,0 +1,9 @@
+lint:
+	helm lint --strict --set service.name=example --set service.version=0.0.1 -f ./ci/empty-values.yaml .
+	helm lint --strict --set service.name=example --set service.version=0.0.1 -f ./ci/simple-values.yaml .
+
+template:
+	helm template -f ci/simple-values.yaml .
+
+template-debug:
+	helm template -f ci/simple-values.yaml --debug .

charts/posit-chronicle/ci/simple-values.yaml

@@ -0,0 +1,26 @@
+image:
+   tag: "latest"
+
+serviceaccount:
+   enabled: false
+   annotations: {
+      eks.amazonaws.com/role-arn: arn:aws:iam::123123123123123:role/chronicle-serviceaccount-role
+   }
+
+config:
+   localStorage:
+      enabled: true
+      retentionPeriod: "7d"
+   logging:
+      serviceLog: "STDOUT"
+      serviceLogLevel: "DEBUG"
+      serviceLogFormat: "JSON"
+   profiling:
+      enabled: true
+   s3Storage:
+      enabled: true
+      bucket: "posit-chronicle-dev"
+      compactionEnabled: true
+
+storage:
+   persistentVolumeSize: 10Gi

charts/posit-chronicle/templates/_helpers.tpl

@@ -61,7 +61,7 @@ Generate selector labels for  various resources
 app: chronicle-server
 {{- end -}}
 
-{{- define "posit-chronicle.serviceaccount.selectorLabels" -}}
+{{- define "posit-chronicle.service.selectorLabels" -}}
 {{- range $key,$value := $.Values.serviceaccount.selectorLabels -}}
 {{ $key }}: {{ $value | quote }}
 {{ end }}

charts/posit-chronicle/templates/serviceaccount.yaml

@@ -1,5 +1,5 @@
 ---
-{{- if $.Values.serviceaccount.enabled -}}
+{{- if .Values.serviceaccount.enabled -}}
 apiVersion: v1
 kind: ServiceAccount
 metadata:
@@ -9,4 +9,3 @@ metadata:
   annotations:
     {{ include "posit-chronicle.serviceaccount.annotations" . | indent 4 }}
 {{- end -}}
----

charts/posit-chronicle/templates/stateful-set.yaml

@@ -9,12 +9,12 @@ spec:
   replicas: {{ .Values.replicas }}
   selector:
     matchLabels:
-      {{- include "posit-chronicle.selectorLabels" . | nindent 6 }}
+      {{- include "posit-chronicle.pod.selectorLabels" . | nindent 6 }}
   template:
     metadata:
       labels:
         {{- include "posit-chronicle.pod.labels" . | nindent 8 }}
-        {{- include "posit-chronicle.selectorLabels" . | indent 8 }}
+        {{- include "posit-chronicle.pod.selectorLabels" . | indent 8 }}
       annotations:
         {{- include "posit-chronicle.pod.annotations" . | indent 8 }}
     spec:

charts/posit-chronicle/templates/svc.yaml

@@ -4,12 +4,13 @@ kind: Service
 metadata:
   name: chronicle-server
   labels:
-    {{ include "posit-chronicle.service.labels" . | indent 4 }}
+    {{- include "posit-chronicle.service.labels" . | nindent 4 }}
+    {{- include "posit-chronicle.service.selectorLabels" . | indent 4 }}
   annotations:
     {{ include "posit-chronicle.service.annotations" . | indent 4 }}
 spec:
   selector:
-    {{- include "posit-chronicle.selectorLabels" . | nindent 5 }}
+    {{- include "posit-chronicle.service.selectorLabels" . | indent 4 }}
   ports:
   - port: {{ .Values.service.rest.port }}
     targetPort: {{ .Values.service.rest.targetPort }}

charts/posit-chronicle/values.yaml

@@ -56,7 +56,7 @@ config:
   https:
     # If https.enabled=true, we will ignore any http
     # values and enable https in our config instead
-    enabled: false 
+    enabled: false
     listen: ":443"
     key: ""
     certificate: ""