Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve issue so subPath: true works correctly #429

Merged
merged 11 commits into from
Oct 25, 2023
Merged

Resolve issue so subPath: true works correctly #429

merged 11 commits into from
Oct 25, 2023

Conversation

tnederlof
Copy link
Contributor

@tnederlof tnederlof commented Oct 23, 2023 •
edited
Loading

This PR sets mountPath to license.file.mountPath/license.file.secretKey when mountSubPath: true. This is the correct syntax when using subPath.

Closes: #427

Also bumps each product to use the new rstudio-library

@tnederlof tnederlof self-assigned this Oct 23, 2023
@CLAassistant
Copy link

CLAassistant commented Oct 23, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

atheriel
atheriel approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@atheriel atheriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM but should probably be tested manually if possible.

charts/rstudio-library/templates/_license-mount.tpl Outdated Show resolved Hide resolved
@tnederlof
Copy link
Contributor Author

This LGTM but should probably be tested manually if possible.

I was able to manually test it with Workbench, mounted correctly (was broken before). Also checked the pod YAML to see the mount path which matched what I expected.

@tnederlof tnederlof requested a review from atheriel October 24, 2023 14:40
@tnederlof
Copy link
Contributor Author

@atheriel ended up bumping the products here

colearendt
colearendt reviewed Oct 25, 2023
View reviewed changes
Copy link
Contributor

@colearendt colearendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one little nit 😄

charts/rstudio-library/templates/_license-mount.tpl Outdated Show resolved Hide resolved
@tnederlof tnederlof requested a review from colearendt October 25, 2023 13:50
@atheriel atheriel merged commit 8d758c3 into main Oct 25, 2023
4 checks passed
@atheriel atheriel deleted the tn-fix-secret-subpath branch October 25, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atheriel atheriel atheriel approved these changes

@aronatkins aronatkins Awaiting requested review from aronatkins aronatkins is a code owner

@dbkegley dbkegley Awaiting requested review from dbkegley dbkegley is a code owner

@christierney christierney Awaiting requested review from christierney christierney is a code owner

@zackverham zackverham Awaiting requested review from zackverham zackverham is a code owner

@jonyoder jonyoder Awaiting requested review from jonyoder jonyoder is a code owner automatically assigned from rstudio/ppm

@jmwoliver jmwoliver Awaiting requested review from jmwoliver jmwoliver is a code owner automatically assigned from rstudio/ppm

@colearendt colearendt Awaiting requested review from colearendt

Assignees

@tnederlof tnederlof

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix mountSubPath arg for licensing
5 participants
@tnederlof @CLAassistant @atheriel @colearendt @actions-user